Closed (fixed)
Project:
Google AdSense integration
Version:
7.x-1.x-dev
Component:
Wishlist
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
2 May 2013 at 13:25 UTC
Updated:
20 Oct 2015 at 10:06 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jcnventuraIt would be possible, not sure however, if this should be handled by the module, or by the theme.. You can create the different ad blocks with the module, and have the theme enable/disable the appropriate block.
Comment #2
jcnventuraComment #3
mrP commented@jcnventura - That's certainly a viable approach. I've struggled with theme level block display alternatives where caching is concerned.
Nonetheless, there are usable solutions out there without needing to build it into this module.
Thanks for your feedback.
Comment #4
jcnventuraAlso, note that Google is rolling out some async code that seems to make it a lot easier to get a responsive ad size. I may add a drupal_alter call to allow themes to change the ad size easily.
I have no idea how to create a generic algorithm to adjust the responsive ad size. I think this really needs to be a theme-level decision.
Comment #5
bunthorne commentedI see that Google is now announcing Responsive Ads as a beta feature, with instructions here . I don't know how to do that with the existing AdSense module.
I'm still a beginner at theming, but I wonder why they can't make use of max-width: 100% for blocks?
Comment #6
jcnventuraI've added support for Google's responsive ads solution.
http://drupalcode.org/project/adsense.git/commit/30e9e7b
Comment #7
mrP commentedVery nice! Thanks!
Comment #9
subhojit777I do not think the issue fixed. I am using this token
[adsense:responsive:xxxx], but I do not responsive ad. This is what I get.Comment #10
subhojit777Seems like it does not work on window resize, but works in mobile devices though. Google ads were rendering properly in mobile devices and there were no horizontal scrollbars. Thanks :)
Comment #12
summit commentedHi,
I do not think this is completely fixed see also https://www.drupal.org/node/2585355
I am not able to get responsive ads working as block or as token.
Greetings, Martijn
Comment #13
jcnventuraOpening two issues only helps to waste everyone's time.
Comment #14
summit commentedHi,
That was not my intention. I thought token and working of the block where different issues.
Sorry if I misinterpreted.
Greetings, Martijn