Get an install error because the - node_access_rebuild(); is undefind in file oa_core.profile.inc.

A quick fix to get the install to work is to edit the file, like this

// prevent notice after install to rebuild permissions
// node_access_rebuild();

Comments

mpotter’s picture

Status: Active » Fixed

Moved this to the oa_core_install hook. Committed to 5a6c366. Hopefully that's a better fix. Sorry I didn't catch this before the Alpha-3 release. It seems that our profile simpletest doesn't catch every problem in the installer.

pancho’s picture

Assigned: Unassigned » pancho
Status: Fixed » Needs work

Better, but not quite there, I'd say...

As I said in the other task,

IMHO, we should call it as late as possible in the 'install_finished' task, so contrib and apps and whatever else can create nodes, before the node access permissions are rebuilt.

Now, moving it into the 'install_finished' task would be fine but unfortunately didn't work, so I'm considering adding a separate hidden task right before 'install_finished'.
By the way, I'm surprised why we're implementing both 'hook_install_tasks' and 'hook_install_tasks_alter'. I think either the one or the other would be cleaner.
Tonight I'm going to have time for taking a closer look on this, therefore assigning to me.

pancho’s picture

Title: Get install error » Fatal error: Call to undefined function node_access_rebuild()

No, we're definitely not there. In the new place the rebuild does no harm, but doesn't work either. After install it's still saying "The content access permissions need to be rebuilt."
(My notion on implementing both 'hook_install_tasks' and 'hook_install_tasks_alter' was bogus though.)

I did some research on this but have not yet finished deciding what would be the right place for this and other post-install tasks. I'm gonna post a followup patch until Monday morning though, and will fix some more issues with installation, so you can roll a beta4 later on Monday.

Argus’s picture

beta4 hurray! ;)

thejtate’s picture

Nice, can't wait!

pancho’s picture

Actually this is no beta4 alpha4 blocker - install works again after the commit in #1.
I hope to get this and some of the remaining bugs fixed tonight. Sorry, that it took longer than I had thought.

mpotter’s picture

I think he means "ALPHA 4" btw ;)

pancho’s picture

Oh, of course, no beta in sight, just an alpha4... ;)

Argus’s picture

Status: Needs work » Fixed

I think this is fixed, never getting this error anymore.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.