Hello, as usual, this module is great! Thank you for your work! just a few usability issues around the library version detection that are causing troubles.

Printer, email and PDF versions - PDF generation library	Unsupported TCPDF version
The currently selected version of TCPDF (unknown) is not supported. Please update to a newer version.

this is happening with tcpdf_6_0_012.zip but it works great, there is no issue that I have seen except the alarmed state of drupal.

this keeps drupal in an alarmed state which means it is risky in that if a real problem occurs I wont know it unless I am specifically checking.

Workaround: So far, none, ignore it or find the old version (source code of this module looks to be keyed to '5.9.001' or less)

Suggestion: update the code to determine less than or greater than or the specific lib version and report that in the admin section instead of telling the user to get a newer version when the newest wont work. Lastly, if this module requires '5.9.001' or earlier, perhaps it should say this on the project page.

Comments

tchurch’s picture

tchurch commented

This is also an issue with the current Drupal 6 version too.
6.x-1.18

Both should be fixed.

But if the code causing the problem should only report if the version is less than the required version then this status alert shouldn't appear anyway.

spydmobile’s picture

spydmobile commented

Agreed - I just did a test and changed the value of vesion in the module, and it still cannot see it, instead it still does the same thing, I think the real issue is that the way the module is testing the version number is no longer compatible with the new library...
Franco

aoristos’s picture

aoristos commented

Since tcpdf 6.x several TCPDF methods and vars were moved to new class files, as stated in the tcpdf changelog.txt.
The tcpdf version definition has moved from the file all/libraries/tcpdf/tcpdf.php to ..all/libraries/tcpdf/include/tcpdf_static.php.

print_pdf.module (in my case version 6.x-1.18+6-dev) can't find the tcpdf version variable anymore. It returns $version = 'unknown', so the statement on line 237 ("if (version_compare($version, '5.9.001', '<')))" becomes true and a warning is shown in Drupal6

Bob123’s picture

Bob123 commented

Subscribing.
Drupal 7.22
Printer, email and PDF versions 7.x-1.2
TCPDF (library) 6.0.018

Vict0rC’s picture

Vict0rC commented

Temporary solution, change line 231 in print_pdf.module
$version = _print_pdf_tcpdf_version();
to, for example
$version = '6.0.018';
Error is gone...

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Fixed

Indeed, Nicola moved the getTCPDFVersion call to another class. I've now fixed this in git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

drvdt’s picture

drvdt commented

Dev 01 oct 2013 fixed this issue.