Download & Extend

Link text left blank, download links still displays

Project:RSS Remote Enclosure
Version:5.x-0.4-beta
Component:Code
Category:bug report
Priority:minor
Assigned:ewlloyd
Status:closed (fixed)

Issue Summary

Greetings,

I've been using this module, quite successfully, for a while now. I've recently come across the need to disable the 'Link Text' completely. For some reason when I leave the 'Link Text' field blank, the 'encl_remote' link still displays a blank link in the $links. For the time being I had to use a theme function to unset the link. While I don't know if its the best approach (not a coder what-so-ever), it seems to be working okay.

<?php
function phptemplate_links($links, $attributes = array()) {
   unset(
$links['encl_remote']);
   
//  While generally not a good idea to call theme functions
    // We really only want to remove a link but otherwise want the standard behaviour
    //   Calling the function directly makes more sense than copying the code
return theme_links($links, $attributes);
}
?>

Keep up the great work on this module!

txcrew

Comments

#1

Assigned to:Anonymous» ewlloyd

Good catch!

I've found it, and I have a fix checked into HEAD. It'll be released shortly.

#2

Status:active» fixed

Fixed in 0.5.

#3

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.