The version information is included in the project's .info file. This is a discouraged practice and should be removed per https://www.drupal.org/node/542202#version.

See https://www.drupal.org/node/1986546#comment-9348621.

===== Original Summary =====

When using drush make, drush will assign the version...7.x-1.7-dev ( I guess drush just makes an assumption )

I'm using this with the geofield module, as I assume many are and the geofield module's .info file states: dependencies[] = geophp (>=1.7)

I realize that this may be able to be resolved there but I believe if a version was predefined in the geophp.info file none of this would matter. This seems to be the logical fix.

Uploading a patch to add the version.

Comments

scottalan’s picture

scottalan commented

Ok, I'd like to add that it seems that drush dl geophp adds the following to the .info file:

; Information added by drupal.org packaging script on 2012-11-05
version = "7.x-1.7"
core = "7.x"
project = "geophp"
datestamp = "1352084822"

and using the following in a .make file:

projects[geophp][type] = "module"
projects[geophp][subdir] = "contrib"
projects[geophp][download][type] = "git"
projects[geophp][download][url] = "http://git.drupal.org/project/geophp.git"
projects[geophp][download][branch] = "7.x-1.7"

adds this:

; Information added by drush on 2013-05-03
version = "7.x-1.7-dev"
core = "7.x"
project = "geophp"
datestamp = "1367619344"

So I'm not sure a patch is necessary, will investigate further. Just wanted to post in case anyone else runs into this issue.

Thanks

kerasai’s picture

kerasai commented
Title: Add version to .info » Remove version from .info
Issue summary: View changes
Status: Active » Closed (works as designed)

Hello version information should not be in the project repository's .info file. This is something that's added to the file by the Drupal.org infrastructure when packaging the releases. See https://www.drupal.org/node/542202#version.

It looks like this was added in 353c85ae7c5229059469d412049fad35360a37ad, and it should be removed.

@scottalan, you're experiencing this weirdness because you've specified the 7.x-1.7 branch. This is actually a tag and if you specify it as so in the .make file drush will add the appropriate version information to the .info file.

kerasai’s picture

kerasai commented
Status: Closed (works as designed) » Needs work
kerasai’s picture

kerasai commented
Issue summary: View changes

  • plopesc committed 2777c5e on 7.x-1.x 
    Issue #1986546: Remove version from .info
plopesc’s picture

plopesc
he/him
Primary language Spanish
commented
Status: Needs work » Fixed

Committed to 7.x-1.x. Thank you for reporting.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.