Needs review
Project:
Pullquote
Version:
7.x-2.1
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
4 May 2013 at 22:40 UTC
Updated:
13 Mar 2016 at 17:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lliss commentedCurrently no wysiwyg button for this but there I did just add notes on doing this in the readme and will move them to the help text in the interface. You can just add another class "pullquote-left" to a pullquote.
Example:
<span class="pullquote pullquote-left">This will appear on the left.</span>Comment #2
lliss commentedComment #3
ryan.ryan commentedThis would take altering the patch from the initial wysiwyg queue correct?
Comment #4
lliss commentedYeah. If you want to take a crack at it that would be awesome. You probably just do a bunch of copy and paste on the existing wysiwyg code that we have working in the latest release.
Comment #5
AndyThornton commentedhi,
i had a go at this. it seems to work fine and have zero copy and paste. i did it against the 7.2 branch, i hope that is okay?
When the patch is applied you will find a new WYSIWYG button that lets you do pullquotes left too.
Comment #6
AndyThornton commentedComment #7
AndyThornton commentedComment #8
AndyThornton commentedComment #9
AndyThornton commentedsorry, i didnt create the patch quite right.
also, there is a new gif file, but that does show up in the diff. i have attached it as well, it goes in the plugin/wysiwyg folder.
Comment #10
AndyThornton commenteddoes anyone still maintain this module?
Comment #11
lliss commentedYes, still maintained...
Your patch had a few issues. Mostly the fact that the editor could not differentiate between a left and a right pullquote so both buttons would highlight.
Here's a revised patch that seems to fix this. I've tried it in TinyMCE but in CKeditor it is functions pretty poorly. Frankly it functions pretty poorly in CKeditor through the WYSIWYG module anyway so it may not be a major issue to include it as is.
Give this a try and let me know if it works well enough.