The "LDAP authentication settings" section appears in all tabls of "User account" form.

A better behaviour would be to restrict its display to the "Account settings" tab only.

Proposed patch is to modify one line in ldapauth_user function :

from:
if (user_access('administer users')) {
to:
if (user_access('administer users') && $category == 'account') {
...or maybe:
if (user_access('administer users') && (!$category || $category == 'account')) {
to handle the case when $category = NULL.

Hope this helps,

-- Denis.

CommentFileSizeAuthor
#1 ldap-198713.patch482 bytesmicahw156

Comments

micahw156’s picture

micahw156
he/him/his
commented
StatusFileSize
new ldap-198713.patch482 bytes

+1

Ahhh, yes, this is much nicer.

Patch rolled using second version and attached.

scafmac’s picture

scafmac commented

Thanks for the catch & the patch. I added it & will commit it to the 5x dev branch soon. I also added a check for "admin ldap modules" as well. Figured there was no reason to show it without that permission.

micahw156’s picture

micahw156
he/him/his
commented
Status: Needs review » Closed (won't fix)

No activity on this issue in over two years. Dev releases on D5 versions of this module have not been updated since first quarter of 2007. With D7 coming, considering this a dead issue. Updating to clear it off of my open issues list.