Add a dedicated @InPlaceEditor plugin annotation

Better: InPlaceEditor.

Also, why do we have namespaces if we can't leverage that anyway? One of the big points of namespaces is precisely that you shouldn't have to worry about classes with the same name… but my guess is that the plugin system doesn't support namespaces?

Upon further consideration — I don't think I understand what name conflict there is?

Well, the problem is that you can't have the same classname twice in a context of a class. You can't change the "active" class (as that's what you add in the file) so the other class (the annotation) need to be different.

+++ b/core/modules/editor/lib/Drupal/editor/Plugin/edit/editor/PropertyEditor.phpundefined
@@ -16,14 +16,14 @@
  *   id = "editor",
  *   jsClassName = "editor",

maybe we should rename the id as well?

Sorry, I didn't see you already had done that rename.

I meant that Edit's "Editors" in general could potentially be renamed to "InPlaceEditors".

But this:

Maybe the editor modules Editor class can be PropertyEditor instead (based on the class description)?

makes no sense, unfortunately.

I now also understand what you were saying in #6: you have to use Drupal\edit\Annotation\Editor;, but the class in which this is used is already called Editor :) Now THAT makes sense!
The solution is simple though: use My\Full\Classname as Another;, i.e. use Drupal\edit\Annotation\Editor as InPlaceEditor. Or doesn't the whole "plugin system annotation thing" allow for aliasing @Editor to @InPlaceEditor?

If that's the case, then I'd rename \Drupal\edit\Annotation\Editor to \Drupal\edit\Annotation\InPlaceEditor. The funny thing is that I originally advocated for something like that, but reviewers said something like "we have namespaces, so why would we want to include qualifiers that we don't need — let's just call it 'editor'"…

Tagging.

+++ b/core/modules/edit/tests/modules/lib/Drupal/edit_test/Plugin/edit/editor/WysiwygEditor.phpundefined
@@ -8,13 +8,13 @@
  *   jsClassName = "not needed for test",
  *   alternativeTo = {"direct"},

Just in general it feels wrong to have camel-case names for this properties.

I guess we should rerole the patch on #1987298: Shorten directory structure and PSR-0 namespacing for plugins

Hey guys, we absolutely should not be using the Editor namespace here. We need that for the editor.module's declaration of editor plugins such as CKEditor.

There wasn't a separate issue for it yet, so I opened it at #1992744: Add a dedicated @Editor plugin annotation.

For this issue I'd be happy to see InPlaceEditor be the defined namespace, and then work on #1874640: Rename edit module to quickedit as a follow-up.

new file mode 100644
index 0000000..f3ea3e6
--- /dev/null
+++ b/core/modules/edit/lib/Drupal/edit/Annotation/Editor.php

This should be InPlaceEditor.php

diff --git a/core/modules/editor/lib/Drupal/editor/Plugin/edit/editor/Editor.php b/core/modules/editor/lib/Drupal/editor/Plugin/InPlaceEditor/Editor.php
similarity index 92%
rename from core/modules/editor/lib/Drupal/editor/Plugin/edit/editor/Editor.php
rename to core/modules/editor/lib/Drupal/editor/Plugin/InPlaceEditor/Editor.php
index 81c23d7..d1eb344 100644
--- a/core/modules/editor/lib/Drupal/editor/Plugin/edit/editor/Editor.php
+++ b/core/modules/editor/lib/Drupal/editor/Plugin/InPlaceEditor/Editor.php

 /**
- * Defines the "editor" Create.js PropertyEditor widget.
+ * Defines the "editor" Create.js InPlaceEditor widget.
  *
- * @Plugin(
- *   id = "editor",
+ * @InPlaceEditor(
+ *   id = "in_place_editor",
  *   jsClassName = "editor",

To further help the namespacing problems we've got with Edit and Editor module, would it be sensible to rename this class to something like Default.php? So it would be core/modules/editor/lib/Drupal/editor/Plugin/InPlaceEditor/Default.php? I mean, I doubt there are going to be too many alternative in-place editors written, but still, the phrase "default in-place editor" makes a lot more sense than "the editor in-place editor".

Sorry I thought this plugin was provided by Edit module. It makes sense as-is. Of course the Editor module should be responsible for the Editor in-place editor. Unfortunately named yes, but it makes sense.

Oh geez, I just realized that in #1886566: Make WYSIWYG editors available for in-place editing, we created a property called "supports_inline_editing". What a mess. I suppose the followup we can name this to "supports_in_place_editing"? I really wish "inplace" where just a single word, or that "inline" was simply acceptable to everyone. Any opinions on this @damiankloip?

#1979784: Factor Create.js and VIE.js out of the Edit module got committed yesterday, which means #27 will no longer apply.

+++ b/core/modules/edit/lib/Drupal/edit/Annotation/InPlaceEditor.phpundefined
@@ -0,0 +1,48 @@
+ * Defines an Editor annotation object.

s/Editor/InPlaceEditor/

+++ b/core/modules/edit/lib/Drupal/edit/Annotation/InPlaceEditor.phpundefined
@@ -0,0 +1,48 @@
+   * The Javascript class name associated with this plugin.

This is gone as of #1979784: Factor Create.js and VIE.js out of the Edit module.

+++ b/core/modules/edit/lib/Drupal/edit/Annotation/InPlaceEditor.phpundefined
@@ -0,0 +1,48 @@
+   * An array of editors that have registered themselves as alternatives to this

s/editor/in-place editor/

+++ b/core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.phpundefined
@@ -133,7 +133,7 @@ function testEditorSelection() {
-    $this->assertEqual('editor', $this->getSelectedEditor($items, $this->field_name), "With cardinality 1, and the full_html text format, the 'editor' editor is selected.");
+    $this->assertEqual('in_place_editor', $this->getSelectedEditor($items, $this->field_name), "With cardinality 1, and the full_html text format, the 'editor' editor is selected.");

Undo this change, see next comment.

+++ b/core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.phpundefined
@@ -164,7 +164,7 @@ function testMetadata() {
-      'editor' => 'editor',
+      'editor' => 'in_place_editor',

No, this should be 'editor', not 'in_place_editor'. It refers to editor.module's in-place editor.

.

Down to mere nitpicks, then this'll be RTBC. Sorry :/

+++ b/core/modules/edit/lib/Drupal/edit/Annotation/InPlaceEditor.phpundefined
@@ -0,0 +1,41 @@
+   * An array of in-place-editors that have registered themselves as

s/in-place-editors/in-place editors/

… or is that actually against English grammar? I'm not a native speaker, you are AFAICT :)

+++ b/core/modules/edit/lib/Drupal/edit/Annotation/InPlaceEditor.phpundefined
@@ -0,0 +1,41 @@
+   * alternatives to this editor.

s/editor/in-place editor/

+++ b/core/modules/edit/lib/Drupal/edit/Annotation/InPlaceEditor.phpundefined
@@ -0,0 +1,41 @@
+   * The name of the module providing the editor plugin.

s/editor/in-place editor/

Wims feedback got adressed

Thanks :) And sorry for all the nitpicking! :(

RTBC +1

Needs reroll

curl https://drupal.org/files/1987140-34.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10973  100 10973    0     0   114k      0 --:--:-- --:--:-- --:--:--  127k
error: patch failed: core/modules/edit/lib/Drupal/edit/Tests/MetadataGeneratorTest.php:9
error: core/modules/edit/lib/Drupal/edit/Tests/MetadataGeneratorTest.php: patch does not apply
error: patch failed: core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.php:9
error: core/modules/editor/lib/Drupal/editor/Tests/EditIntegrationTest.php: patch does not apply

RTBC if comes back green.

Committed 93e8015 and pushed to 8.x. Thanks!

.