Remove test coverage for theme functions

Per #1757550-44: [Meta] Convert core theme functions to Twig templates, retitling to indicate this issue applies to theme_ functions rather than templates. See #1898458: theme_test.module - Convert PHPTemplate templates to Twig Assigned to: widukind for template conversion.

Updated issue summary.

List of functions

re-tagged with "Needs profiling"

#3: 1987414-3.patch queued for re-testing.

Rerolled

profiling this now.. hopefully the patch passes tests

Profiling looks good so long as the patch passes the tests:

=== 8.x..8.x compared (519ffea2643cf..519fff787bd4d):

ct : 40,580|40,580|0|0.0%
wt : 377,639|377,895|256|0.1%
cpu : 334,533|335,159|626|0.2%
mu : 50,206,616|50,206,616|0|0.0%
pmu : 50,271,728|50,271,728|0|0.0%

Profiler output

=== 8.x..1987414 compared (519ffea2643cf..519fffa9aa250):

ct : 40,580|40,580|0|0.0%
wt : 377,639|378,267|628|0.2%
cpu : 334,533|335,045|512|0.2%
mu : 50,206,616|50,206,712|96|0.0%
pmu : 50,271,728|50,272,256|528|0.0%

Profiler output

---
ct = function calls, wt = wall time, cpu = cpu time used, mu = memory usage, pmu = peak memory usage
The registry has been rebuilt. [success]
'all' cache was cleared in self

Reroll + fix errors: templates add a newline at the end.

Here is a revised patch with the change suggested in #17.

Changing to needs review. Come hither, Testbot!

Here's an interdiff for the change in #18.

Thanks @mdrummond!

This looks good, profiling looks good. #14

RTBC:)

This is a conversion issue. Why would it be OK to just change output and tests without any discussion? I'd say it's probably best to not change output at all in this issue and just fix the template.

I'm a fan of the {# Comment control trick #} because it's got relatively low processing to do vs spaceless (which is doing the same thing + removing whitespace inside).

I'd like to recommend we use the comment trick to fix all twig templates with this EOF newline character issue. @Cottser, we can discuss this more later but maybe I should add that to Twig Coding Standards http://drupal.org/node/1823416?

Oh yeah and thanks @Cottser for catching the profiling results were off.

How about this?

Remove white space comment in theme-test-foo.html.twig.

Joel told to do this.

Looks like it works without changing tests? Cool.

Do we still need profiling?

#32: theme-test-twig-conversion-1987414-32.patch queued for re-testing.

@Cottser ran the test locally without a fail/exception Was that through the UI or CLI?

Attached is that function removed.

Whoops, thanks for spotting the extra sneaky file.

Looks good

Wellll, hold up now.

We're still going to have some theme functions in D8 at the point it ships, in a few areas where performance are concerned. Correct?

If so, then I don't think we can convert (at least all of) these tests, because we still need test coverage to ensure theme functions work. This test module already has coverage for template files, so it seems these theme functions are deliberately theme functions.

Or am I missing a cluestick?

We will get the functions out before 8.0.x but we will need to keep this test in for posterity until 9.0.x

Shouldn't we just be removing the tests here along with the theme function functionality?

If we need to convert the theme function to a template, that suggests we're missing coverage elsewhere and could be done in 8.1.x.

Re-titling for now.

@catch Yes, if this is for 9.x then removing the test coverage would appropriate.

Marking this as duplicate of #2716163: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 9 branch. When we remove the bc layer for theme functions, these tests will break and we can remove them.