Closed (fixed)
Project:
JS Callback Handler
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 May 2013 at 03:48 UTC
Updated:
27 May 2013 at 07:21 UTC
Hi,
With the move to the two-phase execution, it seems the handling of JS_NOT_FOUND and JS_ACCESS_DENIED was broken, since these are returned from the first phase, but checked against the return value of the second phase (which doesn't return them).
It also seems like JS_SITE_OFFLINE isn't ever returned?
I've attached a patch that fixes JS_NOT_FOUND and JS_ACCESS_DENIED, although dropping to a full bootstrap to 404 seems heavy for something that's meant to be lightweight. On our setup the memory limit is lower (24MB) for js.php than index.php, so drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL) actually crashes with a memory error in our case. Still, should be better for most people.
| Comment | File | Size | Author |
|---|---|---|---|
| js-404fix-D6.patch | 498 bytes | neilnz |
Comments
Comment #1
michielnugter commentedI commited the patch to the 6.x branch, I found no problems with it and it seems to work just fine.
Thanks for the patch (and the help in general with this module!)