Im getting to know this module.

Test. I subscribed a user to Articles content type.

Im getting the following error on update.

****
The Article has been updated.

* warning: Missing argument 3 for subscriptions_mail_send() in /home/jvrljicak/workspacePHP/dpc-solution/drupal/modules/subscriptions/subscriptions_mail.module on line 84.
* warning: Missing argument 4 for subscriptions_mail_send() in /home/jvrljicak/workspacePHP/dpc-solution/drupal/modules/subscriptions/subscriptions_mail.module on line 84.
* warning: Missing argument 5 for subscriptions_mail_send() in /home/jvrljicak/workspacePHP/dpc-solution/drupal/modules/subscriptions/subscriptions_mail.module on line 84.
* warning: Missing argument 6 for subscriptions_mail_send() in /home/jvrljicak/workspacePHP/dpc-solution/drupal/modules/subscriptions/subscriptions_mail.module on line 84.

function subscriptions_mail_send($mailkey, $name, $to, $subject, $body, $from) {
$mail_success = drupal_mail($mailkey, $to, $subject, $body, $from);
$watchdog_params = array('@name' => $name, '@to' => "<$to>");
if ($mail_success) {
watchdog('subscriptions', t('subscription notification for @name at @to', $watchdog_params));
db_query("UPDATE {subscriptions_user} SET last_sent = %d WHERE uid = %d", time(), $subscriptions->uid);
if (!db_affected_rows()) {
@db_query("INSERT INTO {subscriptions_user} (uid, digest, last_sent) VALUES (%d, %d, %d)", $subscriptions->uid, 0, time());
}
}
else {
watchdog('subscriptions', t('error mailing subscription notification for @name at @to', $watchdog_params), WATCHDOG_ERROR);
}
}

The question would be where to start looking..

thanks

Comments

salvis’s picture

salvis
he/his
commented
Status: Active » Postponed (maintainer needs more info)

Something's wrong here. Is anyone else seeing this?

Have you installed the new mail_edit? Have you removed the old mail_edit files from the Privatemsg module directory?

Maybe you have a corrupt file or some other conflict.

Where are you coming from? (like, did you have an older version of Subscriptions installed, etc.)

jurivrljicak’s picture

jurivrljicak commented

Hi,

Yes i installed the new mail_edit.

I come from 1.9, 2 beta 3. All unsuccessful experiences.

Maybe there is some garbage i am not able to see.

I'll try to debug and find why it is failing to load the user.

thanks

salvis’s picture

salvis
he/his
commented

Do you have Privatemsg 5.x-2.x-dev installed? It's not working correctly and seems to be unmaintained. Try removing it.

jurivrljicak’s picture

jurivrljicak commented

i dont have that installed...

thanks

salvis’s picture

salvis
he/his
commented

It may hurt your installation, if it's there, even if it's disabled!

alexiscott’s picture

alexiscott commented

I also get the same error message, and do not have Private Message installed, or in my modules directory. I am using the 5-2 beta version of subscriptions.

salvis’s picture

salvis
he/his
commented

Hmm... Please search through all of your source code for the strings 'send' and "send" (including the quotes!) and report all .inc or .module files where it's found. If you could also show the lines in each, where it's found, then we might get a better picture faster.

salvis’s picture

salvis
he/his
commented
Version: 5.x-2.0-beta4 » 5.x-2.0-beta8
Status: Postponed (maintainer needs more info) » Closed (fixed)

We're at BETA8 now, and I don't think this is relevant anymore.

Please reopen if this is still an issue...

JStuckman’s picture

JStuckman commented
Version: 5.x-2.0-beta8 » 5.x-2.0-beta9
Status: Closed (fixed) » Active

I'm running at BETA9 and this is still an issue.

# warning: Missing argument 3 for subscriptions_mail_send() in /var/www/drupal-5.6/sites/all/modules/subscriptions/subscriptions/subscriptions_mail.module on line 131.
# warning: Missing argument 4 for subscriptions_mail_send() in /var/www/drupal-5.6/sites/all/modules/subscriptions/subscriptions/subscriptions_mail.module on line 131.
# warning: Missing argument 5 for subscriptions_mail_send() in /var/www/drupal-5.6/sites/all/modules/subscriptions/subscriptions/subscriptions_mail.module on line 131.
# warning: Missing argument 6 for subscriptions_mail_send() in /var/www/drupal-5.6/sites/all/modules/subscriptions/subscriptions/subscriptions_mail.module on line 131.
# warning: Missing argument 7 for subscriptions_mail_send() in /var/www/drupal-5.6/sites/all/modules/subscriptions/subscriptions/subscriptions_mail.module on line 131.
(((((repeated 3 times)))))

It seems like this only happens if the "Send" module is enabled (http://drupal.org/project/send).

I'm hoping that someone can figure this out, because I really need both the Subscriptions and the Send modules on my site...

salvis’s picture

salvis
he/his
commented

Hmm, ok, replace the three instances of

subscriptions_mail_send

with

_subscriptions_mail_send

in subscriptions_mail.module. This will be in BETA10...

JStuckman’s picture

JStuckman commented

This fixes the problem.

However, I have another issue. The "subscriptions_ui" module prevents the "send" module from sending e-mails. I am filing a new bug report for the issue.

Filed bug 212664

JStuckman’s picture

JStuckman commented

Will this change appear in the next version of the software?

salvis’s picture

salvis
he/his
commented

Yes, thanks.

salvis’s picture

salvis
he/his
commented
Version: 5.x-2.0-beta9 » 5.x-2.0-beta10
Status: Active » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.