Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#8 date-1987822-8.patch726 bytestim.plunkett
#4 1987822-route-date-time-4.patch1.37 KBjrglasgow
#1 1987822-route-date-time-1.patch2.3 KBvijaycs85

Comments

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
StatusFileSize
new 1987822-route-date-time-1.patch2.3 KB

Initial patch...

cosmicdreams’s picture

cosmicdreams commented

patch doesn't apply.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

This should also remove the existing code.

jrglasgow’s picture

jrglasgow commented
Status: Needs work » Needs review
StatusFileSize
new 1987822-route-date-time-4.patch1.37 KB

rerolled the patch

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

You missed the controller.

internetdevels’s picture

internetdevels commented
Assigned: Unassigned » internetdevels

We are working today with this issue during Code Sprint UA.

internetdevels’s picture

internetdevels commented
Assigned: internetdevels » Unassigned

.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new date-1987822-8.patch726 bytes

This path has been unused since #492720: Refactor system.js file and use Drupal form states and form ajax.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Yeah just #ajax is used here.

Crell’s picture

Crell commented

I find no errors in the code in the patch. :-)

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

jcisio’s picture

jcisio commented
Status: Fixed » Active

The change in yml file was not committed.

jcisio’s picture

jcisio commented
Status: Active » Fixed

Sorry, wrong patch.

Automatically closed -- issue fixed for 2 weeks with no activity.