Convert system_run_cron() to a new style controller

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -27,4 +27,19 @@ public function run() {
+  /**
+   * Run cron manually.
+   */

Misses @return docs (see below)

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -27,4 +27,19 @@ public function run() {
+  public function runManual() {

i think calling it runManually sounds better

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -27,4 +27,19 @@ public function run() {
+    drupal_goto('admin/reports/status');

Should return a RedirectResponse.
sth like:

return new RedirectResponse('admin/reports/status', array('absolute' => TRUE));

dont forget the use statement;)

I think this patch addresses the items in #3

i think you changed the existing method:P
you should apply the patch from #2 first

Re-rolled the patch and consolidated all of the changes

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -17,14 +17,28 @@ class CronController {
-  public function run() {
+  public function runManually() {

still the changes are on the existing method. run() should stay as is, runManual() is the method i was reffering above

Ahh. That makes more sense.

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -17,14 +17,28 @@ class CronController {
-   * @return Symfony\Component\HttpFoundation\Response
-   *   A Symfony response object.
+   * @return Symfony\Component\HttpFoundation\RedirectResponse
+   *   A Symfony direct response object.
...
-    // HTTP 204 is "No content", meaning "I did what you asked and we're done."
-    return new Response('', 204);
+    return new RedirectResponse('admin/reports/status', array('absolute' => TRUE));

still those changes are irrelevant.

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -17,14 +17,28 @@ class CronController {
+    drupal_goto('admin/reports/status');

instead this drupal_goto should be replaced with the RedirectResponse above

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -17,14 +17,28 @@ class CronController {
+  /**
+   * Run cron manually.
+   */

and after you move it, this should be updated to reflect the @return value

Updated patch attached

looks a lot better now, thanks!

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -27,4 +28,22 @@ public function run() {
+   * @return Symfony\Component\HttpFoundation\RedirectResponse

really minor: while in documentation we should always use the full namespace of the class (including preceding \)

+++ b/core/modules/system/system.routing.ymlundefined
@@ -74,6 +74,13 @@ system_site_maintenance_mode:
+    _controller: '\Drupal\system\CronController::runManual'

lets update the method name here to reflect reality:)

+++ b/core/modules/system/system.moduleundefined
@@ -998,8 +998,7 @@ function system_menu() {
   $items['admin/reports/status/run-cron'] = array(
     'title' => 'Run cron',
-    'page callback' => 'system_run_cron',
-    'access arguments' => array('administer site configuration'),
+    'route_name' => 'system_run_cron',
     'type' => MENU_CALLBACK,
     'file' => 'system.admin.inc',

If you have a MENU_CALLBACK you can directly remove the entry in hook_menu.

Here's an updated patch

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -27,4 +28,22 @@ public function run() {
+    if (drupal_cron_run()) {
+      drupal_set_message(t('Cron ran successfully.'));

Just to note: On the longrun there should be something like a cronRunner service, which has everything injected.

+++ b/core/modules/system/lib/Drupal/system/CronController.phpundefined
@@ -27,4 +28,22 @@ public function run() {
+    return new RedirectResponse('admin/reports/status', array('absolute' => TRUE));

it should be url('admin/reports/status', array('absolute' => TRUE));

+++ b/core/modules/system/system.moduleundefined
@@ -998,9 +998,7 @@ function system_menu() {
   $items['admin/reports/status/run-cron'] = array(
     'title' => 'Run cron',
-    'page callback' => 'system_run_cron',
-    'access arguments' => array('administer site configuration'),
-    'type' => MENU_CALLBACK,
+    'route_name' => 'system_run_cron',
     'file' => 'system.admin.inc',
   );

Just remove all of it

Just to note: On the longrun there should be something like a cronRunner service, which has everything injected.

Agreed, there is already a @todo in the method above:)

Revised patch attached

#18: 1987828-route-system-cron-run-18.patch queued for re-testing.

#18: 1987828-route-system-cron-run-18.patch queued for re-testing.

thats ready, thanks

Committed/pushed to 8.x, thanks!