Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#2 1987862-2-taxonomy_term_feed.patch4.94 KBnick_schuch

Comments

nick_schuch’s picture

Assigned: Unassigned » nick_schuch
nick_schuch’s picture

Status: Active » Needs review
StatusFileSize
new4.94 KB

First attempt.

larowlan’s picture

Status: Needs review » Needs work
+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Controller/TaxonomyTermController.phpundefined
@@ -0,0 +1,36 @@
+    $channel['title'] = config('system.site')->get('name') . ' - ' . $taxonomy_term->label();

this needs to be injected, inject config.factory and set $this->config = $config_factory->get('system.site') then use $this->config->get('name')

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Controller/TaxonomyTermController.phpundefined
@@ -0,0 +1,36 @@
+    $nids = taxonomy_select_nodes($taxonomy_term->id(), FALSE, config('system.rss')->get('items.limit'));

This really needs to go to the Taxonomy service, please add a todo for when 1976298 is in

ParisLiakos’s picture

i think this is going to be a view after #1857256: Convert the taxonomy listing and feed at /taxonomy/term/%term to Views lands
i am not going to postpone this, since the issue above seems stuck for now

ParisLiakos’s picture

Status: Needs work » Closed (duplicate)

actually, the issue above contains the conversion already

nick_schuch’s picture

Assigned: nick_schuch » Unassigned