Unpublishing nodes with webform entity form deletes all webform submission data [#1988372]

If you unpublish a node that has a webform entity form attached to it, all submission data associated with that form will be deleted. All rows from webform_submissions, webform_submitted_data, and all field_data_* fields are wiped of their data.

Update:
With a bit more testing, it looks like anytime you save the parent node of webform entity, the webform submitted data is wiped out.

Mikes's patch below does indeed fix this immediate issue. The other issue is what is the hook_node_presave trying to accomplish and why does the hook_node_save not produce the same results?

Comment	File	Size	Author
#1	webform_entity-truncated-data-fix-1988372-2.patch	973 bytes	MChittenden

Comments

Comment #1

MChittenden commented 6 May 2013 at 19:59

Status	File	Size
new	webform_entity-truncated-data-fix-1988372-2.patch	973 bytes

Patch attached.

For what it's worth this affects the multistep branch.

Comment #2

desmondmorris commented 10 May 2013 at 19:38

Status:

Active

» Needs review

Comment #3

aaronschachter commented 11 May 2013 at 01:55

There is also a webform_entity_node_save() function, which executes the same exact code found in webform_entity_node_presave():

if (isset($node->webform['components'][1]) && count($node->webform['components'][1]) == 1) {
  $empty_component = webform_entity_empty_component();
  if ($node->webform['components'][1] == $empty_component) {
      unset($node->webform['components'][1]);
  }
}