Comments

bdragon’s picture

Version: x.y.z » 7.x-dev

admin/reports/pages is still missing help text. Couldn't locate the other one.

dave reid’s picture

Issue tags: +Novice

Adding novice tag. Anyone want to fix this? :)

reaneyk’s picture

Assigned: Unassigned » reaneyk

I'll start working on it. The link in the description seems to be broken though...

dave reid’s picture

Yeah it is. :/ Should be fairly easy to take a look at statistics_menu() and compare to the current pages covered by statistics_help() and investigate which pages should be added. Thanks for taking this up!

reaneyk’s picture

Status: Active » Needs review
StatusFileSize
new1.34 KB

OK I've added documentation for each of the items in statistics_menu(). I wasn't sure how elaborate they needed to be but I'd be happy to update them if need be.

KC

Status: Needs review » Needs work

The last submitted patch failed testing.

dave reid’s picture

reaneyk: Ok nice work so far. Could you please run diff from the root of your Drupal directory? Otherwise the testing bot won't be able to apply it for testing.

reaneyk’s picture

Status: Needs work » Needs review
StatusFileSize
new1.42 KB

Dave Reid: Thanks for pointing me in the right direction. Here's an updated patch.

KC

spuky’s picture

Status: Needs review » Needs work

for the
admin/reports/pages

you are stating 3 days in the helptext but this can be changed in the settings of the statistics module...

reaneyk’s picture

StatusFileSize
new1.38 KB

Ok, I've changed the text to be more generic.

spuky’s picture

StatusFileSize
new1.38 KB

reupload for the bot... seems he didn't catch it

spuky’s picture

Status: Needs work » Needs review
StatusFileSize
new1.38 KB

does the bot only test if status is needs review ???

dries’s picture

To me, some of these help text feel redundant. We've been removing similarly redundant help texts elsewhere in Drupal. I'm tempted to mark this "won't fix" ...

xano’s picture

Issue tags: +Needs screenshots
xano’s picture

Status: Needs review » Closed (won't fix)
Issue tags: -Needs screenshots

We don't need help texts for the sake of help texts. The UI already shows far too much text to the user. Everything this patch adds should be explained by the page title or possibly other elements on the page.

yoroy’s picture

reaneyk, spuky: thanks for your work on this. don't take it personal! :-)
This particular issue was just very old and the current mission is to *remove* as much help text as possible.