Closed (fixed)
Project:
Hosting
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
7 May 2013 at 02:45 UTC
Updated:
12 Jun 2014 at 08:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
decipheredComment #2
decipheredFixed an issue when testing in a real Aegir setup instead of just a test Aegir setup.
Take into account, I'm not all that happy with the approaches taken in these patches, but then I do think the whole AJAX stuff needs to be completely re-written as well, and that the additional Node add tabs should be provided by the Contextual Administration modle.... so with that said, I think what has been done is good enough for the moment.
Comment #3
decipheredRerolled for Hosting: http://drupalcode.org/sandbox/deciphered/2001932.git/shortlog/refs/heads...
Patch: http://drupalcode.org/sandbox/deciphered/2001932.git/patch/6cd04f56ebce3...
Comment #4
anarcat commentedthis belongs to hosting.
Comment #5
helmo commentedNice, this is something I've wondered about... why didn't we have this before ...
Some remarks:
The first call to _hosting_get_allowed_platforms() is only needed if (is_null($platform)). '$allowed_plats = array($platform => $platform);' could be in the else.
This path seems a bit to generic to my liking....
hosting_site.module uses node/%node/site/add
Ideally this would follow the same pattern, but that would probably be too much effort for this feature.
What about 'node/%node/platform-add-site'?
Comment #6
anarcat commentedagreed.
Comment #7
decipheredUpdated to reflect comments:
http://drupalcode.org/sandbox/deciphered/2001932.git/shortlog/refs/heads...
Patch: http://drupalcode.org/sandbox/deciphered/2001932.git/patch/962095db4c11d...
Comment #8
helmo commentedDarn... merge conflict
Comment #9
decipheredMerge conflicts resolved: http://drupalcode.org/sandbox/deciphered/2001932.git/commit/c836b19d27be...
Comment #10
helmo commentedMerged, thanks