This is an initial patch to update domain.module, domain.info, domain.install and domain_admin.inc to drupal 6.

Additional modules to follow.

CommentFileSizeAuthor
#12 domain.module.7.patch22.79 KBmarcingy
#10 domain.module.6.patch22.54 KBmarcingy
#9 domain.module.5.patch21.36 KBmarcingy
#8 domain.module.4.patch21.49 KBmarcingy
#5 domain.module.3.patch21.12 KBmarcingy
#4 domain.module.2.patch18.52 KBmarcingy
domain.module.patch18.11 KBmarcingy

Comments

marcingy’s picture

marcingy commented
Status: Active » Needs review
agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Awesome start. There are small changes still coming in HEAD, though. But this looks great.

marcingy’s picture

marcingy commented

Thanks for letting me know. I can't see it causing me a problem I'll keep an eye on head and tweak the patches as appropriate.

marcingy’s picture

marcingy commented
StatusFileSize
new domain.module.2.patch18.52 KB

New version of patch which adds a call to menu rebuild when ever a domain is added, updated or deleted.

marcingy’s picture

marcingy commented
StatusFileSize
new domain.module.3.patch21.12 KB

further updates after additional testing

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

If you run across any of these sorts of changes, please let me know if they need to be patched in the 5.x series.

marcingy’s picture

marcingy commented

The additional fixes are related to the need to do isset() testing for missing array items in drupal 6

marcingy’s picture

marcingy commented
StatusFileSize
new domain.module.4.patch21.49 KB
  • Added hook_domainupdate to domain module as rebuild needs to take place after every edit,create and delete
  • removed menu_rebuild call in submit functions to reflect the presence of the new hook in this module
marcingy’s picture

marcingy commented
StatusFileSize
new domain.module.5.patch21.36 KB

reroll to bring back into line with head

marcingy’s picture

marcingy commented
Version: 5.x-1.0beta7 » 5.x-1.0rc1
StatusFileSize
new domain.module.6.patch22.54 KB

re-rolled against head.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

This is frakking awesome.

I don't anticipate many changes from this point. Just some Domain User cleanup -- if we get testers -- and bug fixes.

marcingy’s picture

marcingy commented
StatusFileSize
new domain.module.7.patch22.79 KB

Fixes a notice when creating a node

DZone’s picture

DZone commented

I'm interpreting this as a pretty significant level of progress, agentrickard, and it makes me think maybe a move to D6 is worth considering more carefully.

It would be great to roll up all these patches into a development-stage module release. That would make it a lot easier for us to test. (Please let me know if I am overlooking some other option which makes it easy to apply all these various patches and be confident of having the current versions of the in-progress dev work.)

Rick

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

What I need to do is branch the 5-x code (which I have been planning to do on first release). Then all these changes can go into HEAD.

I would prefer to get 5.x stable before branching.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Needs work

OK. I have finally released the stable version and made a branch for DRUPAL-5.

So the HEAD branch is now clear for upgrade to D6.

There have been changes, though, since this was originally rolled.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs work » Closed (fixed)

Done.