This is a small part of the monolithic patch http://drupal.org/node/125494
Hopefully by breaking them up we can move them through faster.

This part is the fixes to the docblocks.

CommentFileSizeAuthor
#2 diff_125494_comments.patch_1.txt4.03 KBdww
diff_125494_comments.patch4 KBmoonray

Comments

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Doesn't apply cleanly anymore, and has some stray spaces...

Also, I don't see any reason for this:

 /**
  * Implementation of hook_form_alter().
- * Used to add a 'Preview changes' button on the node edit form.
  */

Why remove that bit of explanation from the comment?

dww’s picture

dww
we/he/they
commented
Status: Needs work » Needs review
StatusFileSize
new diff_125494_comments.patch_1.txt4.03 KB

Re-rolled to apply cleanly, fixed spacing problems, fixed the comment for diff_node_form_add_changes(), and restored the explanation to hook_form_alter(). Patch against DRUPAL-5 branch.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

doc changes are always welcome and can just fly in without review. noone makes docs worse, in my experience.

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, DRUPAL-5 and DRUPAL-4-7 (with minor backporting).

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.