The display type settings for fields and table do not work with a view display with row plugin nodes. It should likely not show those options

It looks like it was trying

if (!($view_handler->options['row_plugin'] == 'node' && in_array($view_handler->options['style_plugin'], array('default')))) {
CommentFileSizeAuthor
#3 1989360-panopoly-magic-fielded-view-only-3.patch741 bytespopulist
#1 1989360_views_display_1.patch646 byteshefox
panopoly_magic_view_style_row_plugin.patch717 byteshefox

Comments

hefox’s picture

hefox commented
StatusFileSize
new 1989360_views_display_1.patch646 bytes

Hm, the in_array I can't figure the purpose of. These settings don't work with row style node, but default style plugin is fine with default style plugin.

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Project: Panopoly Magic » Panopoly

Moving this to the main Panopoly issue queue.

populist’s picture

populist commented
StatusFileSize
new 1989360-panopoly-magic-fielded-view-only-3.patch741 bytes

Thanks for pointing this out. IIRC this code is there to make sure that *only* fielded views actually have a switcher enabled since, without a listing of fields, displaying a field list or a table view is not possible.

Attached is a newer patch that only shows fielded views instead of doing the double negative logic.

populist’s picture

populist commented
Status: Needs review » Fixed

Tested on a couple setups and pushed to dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.