Status report page looking for wrong backbone and underscore files

Where did you place the blackbone js file? I found inconsistency in navbar_requirements().

Thanks for sharing your patch. Requires a new release asap.

There is no commit. Why are you changing the status?

Sorry, I changed it to fixed based on.

Well I don't know what happened but now it works fine. I was trying to debug this using dpm and clearing caches multiple times - maybe those extra clear caches did it.

I didn't think the patch was necessary.

The patch fixes an inconsistency bug in the code for sure.

I had the same problem, but it went away by installing the underscore.js library

Patch in #1 worked for me.

Code is:

if (!empty($path) && file_exists($path . '/backbone.js')) {

Should it be:

if (!empty($path) && ( file_exists($path . '/backbone.js') || file_exists($path . '/backbone-min.js')) {

Kieran

@mathieso can you provide a little more info for the patch writer along with your code review?

Patch #1 worked fine for me, however it the patch in #13 might be a good idea to ensure compatibility with people using the un-minified version. I've attached a patch that includes this.

Updating the status.

This patch introduces inconsistencies again. Patch from #1 makes it consistent and is RTBC, the last patch CNW.

Patch in #1 worked for me too.

The module includes the *-min.js files while the status reports page looks the *.js files.

While this is not critical since it doesn't actually breaks anything if you have the correct *-min.js files in the libraries directory, it may be misleading for developers trying to debug navbar, so I'm keeping this as critical for now.

I have only added the files the status page complained about and this has not worked as I have not added the min.js file to the folder.

@hass, yes the module includes the min.js whilst the status page looks for the .js.

That patch is for bringing consistency, since it looks like only the min.js file matters to the module.

I know what this patch does.

Alright, dungeon master.

I have tried #1 patch and it's helping.
I have also download the underscore library and the report log is all green yet the menu isn't working.

Thanks all. Committed to 7.x-1.x in ecefe8c288d999269e993c0a1cc537411a98bd43.

I just installed the most recent dev version of navbar, and my status report indicated that backbone was not present, even though it was located at sites/all/libraries/backbone/backbone-min.js -- And it was not loaded by the module. After renaming the file to "backbone.js" (even though it was minified/production), everything worked as expected. Perhaps there's been a regression here?

@andregriffin: I'm not able to reproduce with the most recent version based on the steps you indicate. Did you have any resolution to your issue and do you have more information?

Note: I'm changing the priority as the critical fix was already committed.

This can only be wrong file names.