Comments

ezra-g’s picture

Component: Code » Theme
ezra-g’s picture

Issue tags: +gizra commons
Zarabadoo’s picture

The initial theming is performed by the following 2 commits:

Now I am going in and moving the expanding partial forms to commons_bw and some class placement cleanup as that was thought to be a nice feature add to any theme that may skin commons.

Zarabadoo’s picture

Zarabadoo’s picture

ezra-g’s picture

Status: Fixed » Needs work
StatusFileSize
new35.41 KB

This is looking awesome!

A few tweaks:

A) Based on the designs at http://drupal.org/node/1969088#comment-7331302, the filters area should have a grey background. It currently has a white background.

B) The asymmetrical padding looks a bit awkward to me. Is there a way we could make this more symmetrical?

Screenshot_5_9_13_1_54_PM-3.png

Zarabadoo’s picture

I focused so much on the widget itself, I missed the new look of the filters. I will fix that up.

Asymetrical padding

Originally the designs had the submit on the right of the form. Then the forms got taller than what was in the comp and there was a risk of the user completely missing the rest of the data to be filled in and causing an error. It was then decided to move the button below so a user has to see all of the form before they can click to submit.

One solution would be to widen the rest of the form to fill up that space below the avatar. it should give the form a more balanced look.

Zarabadoo’s picture

The filters will now be closer to the design.

http://drupalcode.org/project/commons_origins.git/commit/422a435

ezra-g’s picture

Status: Needs work » Fixed

I believe this is now fixed. Hooray!

Automatically closed -- issue fixed for 2 weeks with no activity.