As a followup to #1969088: Changes to group browsing widget & user status updates.

CommentFileSizeAuthor
#8 remove-unused-view-displays-1990318-8.patch1.89 KBdevin carlson
#7 document-tab.png27.24 KBBarisW
#3 1990318-commons_documents-tweaks_for_bw-3.patch6.19 KBitamar
#3 document.png37.72 KBitamar

Comments

itamar’s picture

itamar commented

@ezra-g Please explain what is needed here.

itamar’s picture

itamar commented

Sorry, I realized now you probably meant to add the partial node form to the commons_bw_documents view.

itamar’s picture

itamar commented
Status: Active » Needs review
StatusFileSize
new document.png37.72 KB
new 1990318-commons_documents-tweaks_for_bw-3.patch6.19 KB

Adding the the partial node form to the documents BW view.
document.png

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Great - Thanks!

http://drupalcode.org/project/commons_documents.git/commit/3bb5e51

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

BarisW’s picture

BarisW commented
Version: » 7.x-3.2
Status: Closed (fixed) » Needs work

Not sure if I need to re-open this or create a new issue, but there are still some issues with this code.

See the screenshot. The Document has an extra border (because it has the commons-pod class), where other tabs just have one border.
I've mentioned that the document_bw view has two extra displays (Block and Page) that the other browsing widget views lack. If I remove those displays however, I get an access denied on the Documents tab.

Anyone?

BarisW’s picture

BarisW commented
StatusFileSize
new document-tab.png27.24 KB

And the screenshot.

devin carlson’s picture

devin carlson commented
Assigned: Unassigned » devin carlson
Status: Needs work » Needs review
StatusFileSize
new remove-unused-view-displays-1990318-8.patch1.89 KB

A patch to address #6.

devin carlson’s picture

devin carlson commented
Status: Needs review » Reviewed & tested by the community

Tested #8 by upgrading a fresh install and the visual errors were removed, along with the incorrect views displays.

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Committed #8 to Commons Documents 7.x-3.x.

http://drupalcode.org/project/commons_documents.git/commit/149ab56

BarisW’s picture

BarisW commented

Wow, that was fast. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.