- project page and project info: http://drupal.org/sandbox/guy_schneerson/1791650
- git: git clone http://git.drupal.org/sandbox/guy_schneerson/1791650.git rules_form_alter

This module provides rules access to hook_form_alter() it is significantly different then the Rules Forms Support module, more developer oriented and as a result more powerful with much less code, the tradeoff developers need to be more technical minded. see module page for more information

I maintain two modules (and a number of sandboxes) however both where taken over from other developers and I have no full project permission.
My Project:
http://drupal.org/project/commerce_stock
http://drupal.org/project/commerce_decimal_quantities

Regards,
Guy

Comments

bennetteson’s picture

bennetteson commented
Status: Active » Needs work

You need to give a ready to use git clone.

git clone http://git.drupal.org/sandbox/guy_schneerson/1791650.git rules_form_alter

You need to use drupal_static() instead of global.
http://drupalcode.org/sandbox/guy_schneerson/1791650.git/blob/a1dff1a7c0...

guy_schneerson’s picture

guy_schneerson commented

Thanks @bennetteson
I updated the Issue Summary with the full git clone and will update the code to use drupal_static()

guy_schneerson’s picture

guy_schneerson commented
Status: Needs work » Needs review

Fixed see issue http://drupal.org/node/1991808
diff http://drupalcode.org/sandbox/guy_schneerson/1791650.git/commitdiff/8818...

guy_schneerson’s picture

guy_schneerson commented
Status: Needs review » Needs work

ops realized I was to creative with the $default_value made a last min change will fix shortly

guy_schneerson’s picture

guy_schneerson commented
Status: Needs work » Needs review

much better should work correctly now. Made the following change:
default value is empty array and each call to the hook_form_alter sets the $rules_form_alter_data value see http://drupalcode.org/sandbox/guy_schneerson/1791650.git/commitdiff/6a79...

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

guy_schneerson’s picture

guy_schneerson commented

Dear PA robot
I know you are only a bot and talking to a bot is probably worth than talking to yourself, but what the hack I really like you and I think you are a cool bot. So wanted to let you know that I have taken your advice to hart and our next local meetup will be dedicated to reviewing sandbox modules http://groups.drupal.org/node/298358 :)

Yours sincerely
An organically based Drupal user.

stefan lehmann’s picture

stefan lehmann
Primary language German
Location Hobart
commented
Status: Needs review » Needs work

Hey there,

I really like the idea to be able to change forms via rules. Thanks for this contribution.

Automatic review: some errors, see on Ventral.org.

Manual review:

  • README.txt: there is almost no useful info in this file, see http://drupal.org/node/447604 and http://drupal.org/node/161085
  • .module rules_form_alter_rules_action_info(): various misspellings like: allways, Upadte, conatains etc. Please review.
  • .module LINE 119: misspelling in array index "elemet_array"
  • .module LINE 170 - 173: I think the strings here could go into the t() function.
  • .module: rules_form_alter_rules_access(), you even put a todo here so why did't you implement a proper permission yet before applying for full project access?
  • .module: misspelled variable $crete_missing

I tried for quite a while to get at least a debug output of a comment form, but I failed. I believe that your module works, but it definitely lacks a lot of documentation, how to use it properly. I also don't like the very technical label "Rules_form_alter" popping up in the Rules list. It should be something easier understandable. I think this module needs a bit more polishing. Happy to review it again, when you added some more documentation.

guy_schneerson’s picture

guy_schneerson commented

Hi @Stefan Lehmann
Thank you for the awesome review, all valid points that will be addressed.
My only possible sticking point is the naming of "Rules_form_alter" in the Rules list as I think it reflects the more technical side of the project, but will keep an open mind.
I will address all your point, work on the documentation and provide a step by step getting started (will probably use the comment form).

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

guy_schneerson’s picture

guy_schneerson commented

Still working on it and will soon reopen

guy_schneerson’s picture

guy_schneerson commented
Issue summary: View changes

Updated issue summary.