Hi,

first of all, this is an awesome module. Thanks for that. Now the problem:
When I create a view and display a rendered entity with mediafront players I got the following error:

Strict warning: Only variables should be passed by reference in mediafront_field_formatter_view() (line 144 of ...)

Have attached a patch for that issue.

Hope this helps you when you get the same problem.

CommentFileSizeAuthor
#1 strict-warning-mediafront.patch747 bytesjci

Comments

jci’s picture

jci commented
StatusFileSize
new strict-warning-mediafront.patch747 bytes

Here is the patch ...

enjoylife’s picture

enjoylife commented
Status: Needs work » Needs review

I'm having the same issue as well with the 7.x-2.x-dev version when viewing a linked video in a node. I'm changing the status of this issue. Thank you very much.

enjoylife’s picture

enjoylife commented
Version: 7.x-2.0-rc8 » 7.x-2.x-dev
Status: Fixed » Needs work

I tested this and received this error: "Fatal error: Unsupported operand types in ...\sites\all\modules\mediafront\includes\mediafront.field.inc on line 144."

enjoylife’s picture

enjoylife commented
Status: Needs review » Needs work

For my issue, I resolved it by selecting a preset in my content type (Structure > Content types > content type > Manage Display). I did not have a preset selected before. Do you have a preset selected in your view?

But if someone does not select a preset for their display, this error occurs. It looks like the code wants to use the first preset as a default if no preset is selected, but that something needs to be adjusted so that this error is not thrown when no preset is selected.

jci’s picture

jci commented

The problem occured only if you have no default preset selected, so you are right ...

jci’s picture

jci commented
Status: Needs work » Needs review

Tested the patch on a clean install and it works... Please test the patch again!

enjoylife’s picture

enjoylife commented

Sorry. I applied the patch incorrectly the first time. I've tested this again. The patch removes the Strict warning error for me when no preset is selected. Thank you!

jci’s picture

jci commented
Status: Needs review » Patch (to be ported)
enjoylife’s picture

enjoylife commented
Status: Patch (to be ported) » Reviewed & tested by the community

This doesn't need to be ported. It just needs to be committed. Thanks, jci.

travist’s picture

travist commented
Status: Reviewed & tested by the community » Fixed

Fixed. Thank you!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jci’s picture

jci commented
Issue summary: View changes