Rounded corners not being applied

It's been documented lotsa times, even on the rounded_corners settings page.

You gotta either flatten the image onto a colour of your choice or convert it to png, because JPEGs aren't transparent.

It works on the preview, because that's already a PNG.

Actually, I'm sorry - it looks like the help text is not showing up properly on all the settings forms!
There was a big paragraph of instructions that seems to be hidden! looks like a D7 upgrade thing.

  $form['notes'] = array(
    '#type' => 'markup',
    '#value' => t('
        Note: the rounded corners effect uses true alpha transparency masking.
        This means that this effect <b>will fail to be saved</b> on jpegs
        <em>unless</em> you either <ul>
        <li>convert the image to PNG (using the coloractions filter for that),</li>
        <li>define a canvas underneath it (using canvasactions-define-canvas) or</li>
        <li>underlay a solid color (using coloractions-alpha-flatten) or</li>
        <li>underlay a background image (canvasactions-underlay)</li>
        </ul>
        as a later part of this imagecache pipeline.
        <br/>
      '),
  );

This ain't a proper D7 render array ... Should check all forms for this upgrade oversight....

Reviewing all text help that was supposed to be on the settings pages ...

Aspect Switcher - needed fix
Autorotate - needed fix (the whole form was missing)
canvasactions_definecanvas_form - had some incedental help missing
Watermark - had a missing help warning about using larger files
Rounded corners - as in this issue, needed exposing
Format convert - was missing its watnings about filename confusions (and filesizes)

So... that was an improvement. Pushing that in to dev now. Reclassifying as a documentation bug

I have almost the same problem, but I don't see the rounded corners in the preview either. I have an older version of a site that works fine, but this newest install doesn't.

I use (for both sites):

Scale and Smart Crop 79x79
Desaturate
Rounded Corners (20)
Define canvas 100x100
Rounded Corners (7)

Why is it not working?

The final "Rounded corners (7)" is pretty sure not to work on JPEGs - for the usual reasons.
What do you actually get from that action? I'd imagine that you'd at least see the main (20) corners showing up on the canvas - as long as the canvas is a solid color.

The normal process of elimination is to reduce the problem. Does running JUST step 3 and 4 fail for you? What do you get instead?

Hi, I have the same problem as Lios in the comment #6. I can not see the rounded corners in the preview either. I have a single action: Rounded corners (8) but it doesn't work even if I add a "convert to png" action.

With the previous version (7.x-1.1) of the module this works perfectly. The latest update caused this error.

Thanks.

OK, I can confirm, rounded corners are failing, whether converted to PNG or Flattened - in todays -dev (GD2 at least).
Looks like a lot of callbacks were renamed in the last push, so something has got lost.
This is NOT the issue addressed earlier in the OP where it was just documentation needed. This weeks case is indeed a regression. But we can follow up here because folk have already come to this issue. Normally this would be a new issue though...

OK, found it. Just one function got missed out in the grand rename-everything sweep that just happend.

Works for me now - please pull the latest -dev and try it.

Oops my fault, I guess we better create a new 7.x-1.3 release (and/or unpublish 7.x-1.2) for this regression.

@fietserwin, though it's definitely not elegant code, this is why I put in the 'test suite' a while ago - to quickly spot regressions.
Have you tried that?

I should have done that. I will have a better look at it.

Tested with 7.x-1.3 release.
It works.

Thanks for reporting your findings. Considering this issue fixed now.

Defining canvas doesn't help if source image is JPEG