Closed (fixed)
Project:
User Stats
Version:
5.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Dec 2007 at 17:11 UTC
Updated:
3 Jun 2008 at 22:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
liam mcdermott commentedJust fleshing out the details.
Use cases
Deliverables
Limitations
Time/Cost
This should take around half a day, costing: EUR100. Payment can be from one, or many users: people can donate different amounts to get this work done. It'll take me around one week from the time pledges are made to fit the work in around the other things I have to do. So the work will be due one week from the time the full EUR100 is pledged.
Hope this makes sense. :)
Comment #2
liam mcdermott commentedOne more thing: I can do Paypal, credit/debit card, or direct transfer to a UK bank account (direct transfer will probably cost though, unless you're in the UK).
:)
Comment #3
jaydub commentedI have taken a stab at implementing this feature. In the meantime there has been another release of user_stats so I will port my changes to the current release and post patch here.
Comment #4
liam mcdermott commentedFantastic jaydub! The change that caused that release was very minor, just a couple of lines in hook_cron(). :)
Comment #5
jaydub commentedOk I've got a patch ready with this feature...although in desire to add a few more things I've perhaps added in some unrelated features to the patch. Feel free to take a look at the other things and if they are of value then they can go in as well. If not then I can do some extracting and re-roll the patch (but will be on holiday in 4 days).
In this patch:
Because I have a multisite setup with shared user tables, I've also modified user_stats to allow the selection of a previously created profile field to use as the post count field as in my case there would be different post counts per site for a single user. If you think that could be of value I can post another patch.
Comment #6
liam mcdermott commentedThis looks great. I've tested and read through the code pretty thoroughly. Thanks for adding this much-needed functionality! On the down-side there are a few changes (nothing major):
variable_get('user_stats_postcount_profile_field', ''), this should be hardcoded to:'user_post_count'for the moment (did some of your multi-site stuff creep in there? ;) );The user_stats.install file needs updating too, I'll gladly sort that out after we've got this update committed though. :) Overall problems with getting this committed are very small, I'm enthusiastic about the added functionality. Should get a chance to write some documentation this weekend too!
That does sound like a good idea, yes. Definitely a seperate patch (and new feature request).
Comment #7
jaydub commentedOk, took care of #1-#4 although I didn't look too hard for the wording changes...
For user_stats.install file I am not sure what needs updating...I've separately uploaded a patch to the install file to enable PostgreSQL support (although untested with the module doh!). http://drupal.org/node/214040
For the ability to choose the profile field to use for post count, do you want me to try and patch against the current module or send that patch assuming the above patch is applied (easier) ?
Comment #8
liam mcdermott commentedProbably easier to just do things in sequence. Am going to get this patch committed within the next hour, so less work for you. :)
Comment #9
liam mcdermott commentedCommitted. Rock on. Am going to sort out the install file now. :)
Comment #10
jmai commentedI'm getting a blank settings page for the new committed file 1.2.2.6 user_stats.module.
Comment #11
liam mcdermott commentedThat should have been fixed in the latest CVS version. Try it out and raise a bug if you still get problems. :)
Comment #12
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #13
amnion commentedHow do I apply the above patch? I don't want to mess anything up.