More details: https://support.sharethis.com/customer/portal/articles/961937

CommentFileSizeAuthor
#5 0001-CNS-flags-format-Handled-string-types-for-the-flags-2.patch180.61 KBronsharethis
#3 0001-CNS-flags-format-Handled-string-types-for-the-flags.patch181.6 KBronsharethis
sharethis-cns-changes.patch23.56 KBronsharethis

Comments

ronsharethis’s picture

ronsharethis commented
Priority: Normal » Minor
Status: Needs review » Needs work
jvalencia’s picture

jvalencia commented
Priority: Minor » Critical

We definitely need this to be out soon, so that users can edit their options related to CNS, but this patch doesn't conform to Drupal guidelines:
https://drupal.org/coding-standards

Changing this to critical as it could potentially break publisher's sites if they can't disable. Anyone want to try cleaning it up and resubmitting?

Here's the API page:
https://support.sharethis.com/customer/portal/articles/961937

There's an odd external call in the patch. It grabs global settings to turn off the feature from ShareThis in case there is a critical failure. (I think, but I'll look into it).

ronsharethis’s picture

ronsharethis commented
StatusFileSize
new 0001-CNS-flags-format-Handled-string-types-for-the-flags.patch181.6 KB

This is the latest working patch.

Please test and use.

jvalencia’s picture

jvalencia commented

As an added note, this coder module should help you conform to style guidlines:
http://drupal.org/project/coder

There is a list of modules at the bottom of https://drupal.org/coding-standards that could help too.

ronsharethis’s picture

ronsharethis commented
StatusFileSize
new 0001-CNS-flags-format-Handled-string-types-for-the-flags-2.patch180.61 KB

This updated patch includes changes made in the repository.

This outdates the patch posted on June 7.

kerasai’s picture

kerasai commented

This is a duplicate of #1931224: Add option to disable the new CopyNShare "See more..." function. The patch in https://drupal.org/node/1931224#comment-7551953 is included in the latest dev release.

kerasai’s picture

kerasai commented
Status: Needs work » Closed (duplicate)