There's a "custom.js" file in the js folder which is being included via the zurb-foundation.info file.
There's 2 problems with this: first of all this theme is supposed to be used as a base theme and editing it directly is technically hacking it so if we want to include some custom boilerplate js for the user let's do that in the subtheme please!
Also, the custom.js file uses a jQuery document ready approach, whereas the more appropriate way would be to have a Drupal.behaviors block wrapper inside a closure, like custom modules do.
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | zurb-foundation-1992174-custom-js-1.patch | 1.99 KB | alexweber |
Comments
Comment #1
alexweber commentedPatch attached that does all of the above:
Comment #2
kevinquillen commentedGood work. Committed to dev.
Comment #3
alexweber commentedAwesome, thanks!