Needs work
Project:
Community Media Starter Kit (Moderate)
Version:
7.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
10 May 2013 at 21:46 UTC
Updated:
22 Nov 2014 at 18:15 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jdcreativity commentedstill an issue on a Pantheon install.
Comment #2
kreynen commentedIf you go to admin/reports/status, you'll see that while the install profile is listed (cm_starterkit_moderate-) there's no version number. This means that while the variable telling Drupal which directory in /profiles to use, the profile "module" itself isn't active in the system table. You could use SequelPro or phpMyAdmin to adjust the status of that row in the system table, or you can install https://drupal.org/project/profile_switcher and reselect cm_starterkit_moderate. We've seen this happen a few times when running update.php, but I think that was caused by including a module dependency in the profile's .info file that wasn't enabled. This forced the profile "module" to be disabled.
Never seen it on a clean install, but will do more testing.
Comment #3
avguy commented#1170362: Install profile is disabled for lots of different reasons and core doesn't allow for that seems to talk about this. We should look at what Atrium and Commons are doing about the issue.
Comment #4
avguy commentedComment #5
avguy commentedAfter checking against: http://cgit.drupalcode.org/cm_starterkit_difficult/tree/cm_starterkit_di... these are the required dependencies disabled on our dev site:
comment
dashboard
shortcut
toolbar
overlay
Comment #6
stefanwray commentedAric, I found the same thing that the distribution was not showing up in the status report. I had 3 of the required modules turned off. They were
comment
overlay
and one other one that I can't remember, sorry
so the idea is to decide which to make not required right?
Comment #7
stefanwray commentedI propose that at least the Comment module not be on part of the dependency list
Comment #8
kreynen commentedThis is not fixed, but is less of an issue now that the fix for #2368489: Reprocess profile activation even when the profile isn't changing is included in the distributions.
To really fix this, we need to decide which modules are truly a dependency of the distributions and which modules should be enabled using module_enable in the install process. Only modules that should really never be disabled should be included in the profile's .info as a dependency. Everything else we want enabled by default should be handled with module_enable in the .install. The modules enabled in the .install can be disabled without causing this problem.
Looking at the list in http://cgit.drupalcode.org/cm_starterkit_easy/tree/cm_starterkit_easy.info, I'd suggest limiting the list in the .info file to...
dependencies[] = block
dependencies[] = contextual
dependencies[] = help
dependencies[] = image
dependencies[] = list
dependencies[] = menu
dependencies[] = number
dependencies[] = options
dependencies[] = path
dependencies[] = taxonomy
dependencies[] = search
dependencies[] = toolbar
dependencies[] = field_ui
dependencies[] = file
dependencies[] = rdf
dependencies[] = breakpoints
dependencies[] = picture
dependencies[] = views
dependencies[] = ctools
dependencies[] = pathauto
dependencies[] = module_filter
dependencies[] = wysiwyg
dependencies[] = update
Moving to module_enable in the .install...
dependencies[] = color
dependencies[] = comment
dependencies[] = fullcalendar
dependencies[] = views_ui // Pantheon tells users to disable this for performance reasons
dependencies[] = dblog
dependencies[] = imce
dependencies[] = imce_wysiwyg
dependencies[] = cm_checklist
dependencies[] = cm_slideshow
dependencies[] = views_slideshow
dependencies[] = flexslider
dependencies[] = shortcut
dependencies[] = overlay
dependencies[] = dashboard
The modules in the .info file should be limited to modules no one would recommend building a site without.
The modules in the .install file can actually be expanded to include anything that will make the initial user experience better. I'd like to add cm_starter_pages now and cm_starter_pathauto and cm_starter_wysiwyg when those Feature exports are ready.