I know about the 128 limitation of the alias column, but I DON'T think that the pattern field must be limited to 128. I have a pattern that has more than 128 chars, but the resulting string has less than 100 chars. So, can the pattern field length limitation be removed and replaced with a warning or something like this?

Thanks,
Stefan V

Comments

stefan vaduva’s picture

stefan vaduva commented
Priority: Critical » Normal
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Yes, that is a great point. Just to make the case for this clear, can you paste the example of your pattern that pushes it beyond 128 characters?

Regardless I'll look into adding this.

stefan vaduva’s picture

stefan vaduva commented

example: "content/[field_type_announce-formatted]-[field_type_product-formatted]-[field_number-formatted]-bucati-[field_judet-formatted]-[nid]" will produce something like "content/public-laptop-3-bucati-suceava-94"

Greggles, thanks alot for looking into it!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

So, your field is 132 characters. What do you think seems like a reasonable limit? 256? 512?

stefan vaduva’s picture

stefan vaduva commented

What about no limit? And maybe a warning if the resulted string (after submit) is longer than 128 chars... Those are only some ideas from a usability freak ;) In my opinion the limitation for the input field has no sense... but again, this is only my opinion.
Anyway, this is a great module.. I don't know how I've lived without it until now :). You make a very good job and I must thank you for that!!!

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

That is a great question. I looked it up on the forms reference because I wasn't sure. If we don't set one then the default is applied (128) so we need to set something.

The only real concern would be that the database doesn't hold all the data. In fact, the data is stored in a column that can hold very large data, so how about a couple thousand?

And you are quite welcome. In my opinion one of the best way to show thanks for a module is to provide good ideas for improving it, to read the other issues in the queue, help with testing, and provide feedback for other issues. If you have time for that, I always appreciate it.

stefan vaduva’s picture

stefan vaduva commented

Ah, then I guess that a large number of chars will be ok.

As for testing and feedback, I assure you that I will do that :). I've just begun to use your module and if I will see something is wrong or I have an idea to improve it, I will tell you. For now, this was the only issue I've found. I will also look at the issues in queue and if I can help, I will help.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Problems with pattern field length » allow really long patterns
Status: Active » Patch (to be ported)

I committed a fix for this to the 5.x-2.x branch. It should be re-packaged within a few hours. It still needs to be applied to the HEAD branch.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Patch (to be ported) » Fixed

committed to HEAD as well

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.