Hey folks,

Loving this admin theme to death. There are a few odds and ends that could use touchups, but overall, looking awesome. I intend to help out with those things as I find them, starting with views. It looked like there were some views-specific styles already in there, but all they really did was strip out the default views styles. Attached below is a patch that touches up the theming, and makes the form responsive (Though I can't really see anyone doing Views configurations on mobile, it was a simple fix.) Also attaching before & after screens.

Comments

wbobeirne’s picture

Status: Active » Needs review
StatusFileSize
new2.99 KB

Attaching patch

tkoleary’s picture

@wbobeirne

Thanks! I think the thrust of this issue is correct but I'd like to tweak the styling just *slightly*.

If I pass you a png can you make some adjustments? If not I'll apply your patch to my local and fiddle with it.

-Kevin

wbobeirne’s picture

Status: Needs review » Needs work

Hey Kevin, I'd be happy to. Just post it here and I'll see what I can do.

tkoleary’s picture

@wbobeirne Will do. Need a few days to wrap up other deigns done in Portland and post to issues.

tkoleary’s picture

BTW I credited you in the commit messages of those patches but I didn't see that reflected in your profile. Does that only happen when I roll a release or did I do it wrong?

wbobeirne’s picture

StatusFileSize
new3.22 KB

Re-rolling patch for latest dev release.

As for the commits, thanks so much for caring to credit me! The way you have to credit someone is by changing the author of the commit, see here for a quick how-to: https://makandracards.com/makandra/1717-git-change-author-of-a-commit

I'm not sure how easy it would be to amend commits that have already been pushed to the remote repository though.

tkoleary’s picture

Status: Needs work » Fixed

Pushed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.