Closed (fixed)
Project:
Ember
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
12 May 2013 at 00:33 UTC
Updated:
21 Jun 2013 at 15:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
wbobeirne commentedAttaching patch
Comment #2
tkoleary commented@wbobeirne
Thanks! I think the thrust of this issue is correct but I'd like to tweak the styling just *slightly*.
If I pass you a png can you make some adjustments? If not I'll apply your patch to my local and fiddle with it.
-Kevin
Comment #3
wbobeirne commentedHey Kevin, I'd be happy to. Just post it here and I'll see what I can do.
Comment #4
tkoleary commented@wbobeirne Will do. Need a few days to wrap up other deigns done in Portland and post to issues.
Comment #5
tkoleary commentedBTW I credited you in the commit messages of those patches but I didn't see that reflected in your profile. Does that only happen when I roll a release or did I do it wrong?
Comment #6
wbobeirne commentedRe-rolling patch for latest dev release.
As for the commits, thanks so much for caring to credit me! The way you have to credit someone is by changing the author of the commit, see here for a quick how-to: https://makandracards.com/makandra/1717-git-change-author-of-a-commit
I'm not sure how easy it would be to amend commits that have already been pushed to the remote repository though.
Comment #7
tkoleary commentedPushed. Thanks!