Hey folks,

Using Ember with the Workbench module, and some of Workbench's theming isn't going so hot with Ember. Simple patch that fixes something at the desktop level, and makes it go to mobile gracefully. Patch attached below, also attaching before & after screens.

CommentFileSizeAuthor
#1 ember-workbench-1993240-1.patch1.18 KBwbobeirne
ember-workbench-after.png143.2 KBwbobeirne
ember-workbench-before.png116.93 KBwbobeirne

Comments

wbobeirne’s picture

wbobeirne commented
Status: Active » Needs review
StatusFileSize
new ember-workbench-1993240-1.patch1.18 KB

Attaching patch

brst t’s picture

brst t commented

20131102 - removed by author

wbobeirne’s picture

wbobeirne commented

That's also a suitable fix, but I also added a responsive aspect to it to single column it at mobile, which makes the "My edits" table considerably more legible at mobile. You can see it in the screenshots.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Title: Workbench theming » Ember should provide responsive css for Workbench
Status: Needs review » Reviewed & tested by the community

+1 - this is great. Tested using latest 7.x-1.x-dev (34027ec) along with stable workbench and it does well.

Also updated the title so as to clarify why the extra CSS is necessay (re: #2 and #3).

tkoleary’s picture

tkoleary commented
Assigned: Unassigned » tkoleary
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.