Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 May 2013 at 10:29 UTC
Updated:
24 Sep 2013 at 16:24 UTC
This module display a list of your public beevou vouchers templates, it requires an active beevou.net account that will be used to connect to the beevou.net API with your credentials, also you can specify the data to display, like the voucher icon and description.
Working example: http://beevou.com/examples/drupal/?q=beevou
git clone --branch master jmalarcon@git.drupal.org:sandbox/jmalarcon/1989950.git
Comments
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxjmalarcon1989950git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
hazaHi,
I had a quick review of you code and I have a few remarks about it.
First, it seems that even if you have a 7.x-1.x branch, your most up to date branch is still the "master" branch.
According to the branching convention, you should commit all your code on the 7.x-1.x branch.
I only had a look on the "master" branch.
First, you hardcoded both
BEEVOU_CLIENT_IDandBEEVOU_CLIENT_SECRETids. I don't know how it is supposed to work, but I guess that those need to be changed with personal credentials to each one that want to use your module ?Also, you use cURL to query the service. That's fine, but what happen when a user want to use your module on a server that doesn't have cURL on it ? Maybe you should check that there is cURL enabled ? You can do that using hook_requirements for example. Check the color module (D7 core) for a live example, it checks if GD is present or not on the server.
Comment #3
PA robot commentedClosing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.