There are module folders in the destination selection. These folders need not be shown.
See screen image.

CommentFileSizeAuthor
#6 Modules 2013-05-16 17-22-14.png799.82 KBAnonymous (not verified)
pop-up.jpg129.34 KBAnonymous (not verified)

Comments

kriboogh’s picture

Status: Active » Closed (duplicate)
Anonymous’s picture

Version: 7.x-1.0 » 7.x-1.1
Status: Closed (duplicate) » Active

Reopened this issue.

Multiple folders also present in 7.x-1.1.

kriboogh’s picture

Status: Active » Postponed (maintainer needs more info)

Could you provide me with some more info on your setup as I don't see this happening on mine (I'm running Mac Lion, Drupal 7.22). Do you see anything in the message logs (Drupal, Apache access/error logs). Thanks.

Anonymous’s picture

CentOS
Apache 2.2.19
MySQL 5.1.48
Php 5.3.9
Drupal 7.22
installed on vps.

There are no erros in drupal and apache logs.
There is no difference in the folders showing in v1.0 or v1.1.
I tried reinstalling the module, clear caches, emtied cache_ fields in de database: no result.

In the folder selection popup: some modules I use in Drupal, some are not switched on.
I don't see differences in these modules (in the selection) and other modules.
The modules in the selection are in the all/module folder, with other modules.

kriboogh’s picture

I can't seem to reproduce this.
The only reason I can see why this would be happening is because the .module file in those listed paths can not be found.
If you could replace some lines of code into module_install.api.inc (on line 66, the entire if case with this)

        directory = $dir . '/' . $file;
        drupal_set_message('test: ' .  $directory . '/' . $file . '.' . $type);
        $real_path = realpath($directory . '/' . $file . '.' . $type);
        if (!$real_path && !in_array($directory, $found) && !in_array($directory, $exceptions)) {
          $found[$directory] = $directory;
        }
        else {
          drupal_set_message('ignore: ' . $real_path . in_array($directory, $found) . in_array($directory, $exceptions) );
        } 

Maybe this woud shed some light on this one.

Anonymous’s picture

StatusFileSize
new799.82 KB

Screen image attached.
The modules in the pop-up are not 'ignored' in the listing.
Hope this helpes.

Martin

kriboogh’s picture

If these folders don't contain a .module file there is not much to resolve this if guess. IF they do contain a module file, I don't see why just these would not pass the if test.

Edit:
ok i see whats going on, the module file is not named the same as the modules folder. for example: google_analytics/googleanalytics.module. I'll cook up a fix for that.

Thanks for running the code.

Anonymous’s picture

V.x-1.2 solves the name issue!

There are modules without a .module file in the module folder. For example the 'i18n_contrib' and the 'select_with_style' modules. Thay stay in the popup. Maybe they can put in an exception list?

See the tarballs:
http://drupal.org/project/i18n_contrib
http://drupal.org/project/select_with_style

The last version is good enough for me to work with: it gives an easy way to structure the modules in a multisite environment. Thanks.

Martin

kriboogh’s picture

Version: 7.x-1.1 » 7.x-1.2
Status: Postponed (maintainer needs more info) » Closed (fixed)

Good to hear that.

You can use the hook_module_install_exceptions and hook_module_install_includes in your own module to either exclude or even include other directories. See the module_install.api.php file for examples.