The label is placed inline where all other content types use Above. Patch follows.

CommentFileSizeAuthor
#5 1993800-5-commons_wiki-topic-label.patch1.01 KBBarisW
#1 1993800-commons_wiki-topic-label.patch555 bytesBarisW

Comments

BarisW’s picture

BarisW commented
Status: Active » Needs review
StatusFileSize
new 1993800-commons_wiki-topic-label.patch555 bytes
ezra-g’s picture

ezra-g commented
Status: Needs review » Needs work

Thanks for the patch! This just needs an upgrade path and looks RTBC.

BarisW’s picture

BarisW commented

What upgrade path are you looking for? A features revert will set it back, do we need an update hook for this?

ezra-g’s picture

ezra-g commented

We typically do an upgrade hook that causes a feature revert. See existing Commons .install files for an example.

BarisW’s picture

BarisW commented
Status: Needs work » Needs review
StatusFileSize
new 1993800-5-commons_wiki-topic-label.patch1.01 KB

Ah ok. No problem, here you go!

devin carlson’s picture

devin carlson commented
Status: Needs review » Reviewed & tested by the community

The patch in #5 applied cleanly and changed the label position for the Topics field from "inline" to "above".

Tested by installing commons, checking the label position for the Wiki content type's Topics field, applying the patch and running the included update function and finally rechecking the label position for the Wiki content type's Topics field.

The Commons Origins theme treats both "inline" and "above" labels the same so there's no need to modify any styling.

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Committed #5 to 7.x-3.x.

Thanks!

devin carlson’s picture

devin carlson commented

http://drupalcode.org/project/commons_wikis.git/commit/06564ea3b8d8a7d25...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.