Panels node translation loses $_GET parameters

CommentFileSizeAuthor
#11 panels-panels-node-translation-1994046-11.patch1.38 KBjaperry
#8 panels-panels-node-translation-1994046-8.patch1.37 KBjaperry
#2 panels-panels-node-translation-1994046-2.patch545 bytesgrisendo

Comments

grisendo’s picture

grisendo commented

I attach a patch

grisendo’s picture

grisendo commented
StatusFileSize
new panels-panels-node-translation-1994046-2.patch545 bytes
grisendo’s picture

grisendo commented

I forgot to tell that this issue is a bad thing since when translating a node, reference to original-language NID (TNID) is done via a url parameter, so GET parameters are needed to be kept. Otherwise a new node will be created with no language-relationship with the original one.

grisendo’s picture

grisendo commented
Status: Active » Needs review
mlanth’s picture

mlanth commented
Issue summary: View changes

Recently encountered this issue myself, and found this issue through searching.

Everything is working fine after applying grisendo's patch.

xaa’s picture

xaa commented

patch #2 working. thank you.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Patch was also working for me

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new panels-panels-node-translation-1994046-8.patch1.37 KB

So there are some other underlying issues with the node_query, I made some changes here that needs review before it gets committed.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented 
+++ b/panels_node/panels_node.module
@@ -183,14 +183,12 @@ function panels_node_hook_form(&$node, &$form_state) {
-      return drupal_goto('node/add/panel/choose-layout', $opts);
+      drupal_goto('node/add/panel/choose-layout', array('query' => drupal_get_query_parameters()));
...
-      return drupal_not_found();
+      drupal_not_found();

@japerry Why remove the 'return' statement for drupal_not_found? It doesn't look like drupal_not_found() has a die() or exit() so this code could continue to execute. (I could be wrong, but see any when perusing drupal_deliver_page...)

drupal_goto() should be fine to remove because it calls drupal_exit() which ends in an exit statement and nothing diverts that execution path. So +1 to that change.

robmcbryde queued 8: panels-panels-node-translation-1994046-8.patch for re-testing.

japerry’s picture

japerry
Location KOMK
commented
StatusFileSize
new panels-panels-node-translation-1994046-11.patch1.38 KB

Update with MENU_NOT_FOUND instead of the page deliver function.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Been using this for some time now. Looks good, back to RTBC.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2423733: Plan for Panels 7.x-3.6 release
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Thanks Joel for the update -- this looks good. fixed!

  • japerry committed 9c27c89 on 7.x-3.x 
    Issue #1994046 by japerry, grisendo, joelpittet: Panels node translation
sillo’s picture

sillo commented

Hello. Awesome patch - it worked like a charm!
(For non-devs, you can use module Patch Manager to patch modules - please read description about security on production sites).
Is this patch / fix going to be implemented in the next Panels update?
Im not experienced with patches, but if Panels gets a update, would i have to re-patch the module?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kopeboy’s picture

kopeboy
Primary language Italian
Location Milan
commented

What module/submodules do we have to enable to be able to do this?