Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Panels node translation loses $_GET parameters
Comment | File | Size | Author |
---|---|---|---|
#11 | panels-panels-node-translation-1994046-11.patch | 1.38 KB | japerry |
Comments
Comment #1
grisendo CreditAttribution: grisendo commentedI attach a patch
Comment #2
grisendo CreditAttribution: grisendo commentedComment #3
grisendo CreditAttribution: grisendo commentedI forgot to tell that this issue is a bad thing since when translating a node, reference to original-language NID (TNID) is done via a url parameter, so GET parameters are needed to be kept. Otherwise a new node will be created with no language-relationship with the original one.
Comment #4
grisendo CreditAttribution: grisendo commentedComment #5
mlanth CreditAttribution: mlanth commentedRecently encountered this issue myself, and found this issue through searching.
Everything is working fine after applying grisendo's patch.
Comment #6
xaa CreditAttribution: xaa commentedpatch #2 working. thank you.
Comment #7
JeroenTPatch was also working for me
Comment #8
japerrySo there are some other underlying issues with the node_query, I made some changes here that needs review before it gets committed.
Comment #9
joelpittet@japerry Why remove the 'return' statement for drupal_not_found? It doesn't look like drupal_not_found() has a die() or exit() so this code could continue to execute. (I could be wrong, but see any when perusing drupal_deliver_page...)
drupal_goto() should be fine to remove because it calls drupal_exit() which ends in an exit statement and nothing diverts that execution path. So +1 to that change.
Comment #11
japerryUpdate with MENU_NOT_FOUND instead of the page deliver function.
Comment #12
joelpittetBeen using this for some time now. Looks good, back to RTBC.
Comment #13
DamienMcKennaComment #14
japerryThanks Joel for the update -- this looks good. fixed!
Comment #16
sillo CreditAttribution: sillo as a volunteer commentedHello. Awesome patch - it worked like a charm!
(For non-devs, you can use module Patch Manager to patch modules - please read description about security on production sites).
Is this patch / fix going to be implemented in the next Panels update?
Im not experienced with patches, but if Panels gets a update, would i have to re-patch the module?
Comment #18
kopeboy CreditAttribution: kopeboy commentedWhat module/submodules do we have to enable to be able to do this?