pgsql _db_query() shows each query error twice [#19942]

Comment	File	Size	Author
	database.silence.query.diff	1.2 KB	danielc

Comment #1

danielc CreditAttribution: danielc commented 8 April 2005 at 00:43

Can this please be applied to 4-6 and HEAD?

Log in or register to post comments

Comment #2

Dries CreditAttribution: Dries commented 8 April 2005 at 11:41

How can we reproduce this? No matter what I do, I only see each error reported once.

(We try to avoid the use of @ to surpress errors.)

Log in or register to post comments

Comment #3

danielc CreditAttribution: danielc commented 8 April 2005 at 13:36

Ah! It's just happening with PostgreSQL. I noticed it there and assumed the same issue existed with MySQL. Sorry for the confusion. Please commit to database.pgsql.inc only.

Log in or register to post comments

Comment #4

danielc CreditAttribution: danielc commented 23 April 2005 at 14:35

Title:

_db_query() shows each query error twice

» pgsql _db_query() shows each query error twice

Add "pgsql" to title.

Test script:

<?php
// so we don't need to include bootstrap
function variable_get($name, $default) {
return $default;
}

ini_set('include_path', 'd:/webroot/drupal/includes');
require_once 'database.pgsql.inc';
$db_url = 'pgsql://usr:pw@localhost/drupal';
$active_db = db_connect($db_url);
_db_query('a REALLY bad query');

Log in or register to post comments

Comment #5

danielc CreditAttribution: danielc commented 23 April 2005 at 14:37

The test script got ripped out. Perhaps because I used an opening PHP tag w/o a closing one. Let's try again:

// so we don't need to include bootstrap
function variable_get($name, $default) {
  return $default;
}

ini_set('include_path', 'd:/webroot/drupal/includes');
require_once 'database.pgsql.inc';
$db_url = 'pgsql://dropper:ak17q8l10@localhost/drupal';
$active_db = db_connect($db_url);
_db_query('a REALLY bad query');

Log in or register to post comments

Comment #6

Dries CreditAttribution: Dries commented 25 April 2005 at 18:02

We're not fond of using '@'. I'll await feedback from Adrian, who maintains the PostgreSQL port. He might be able to suggest an alternative/better fix.

Log in or register to post comments

Comment #7

danielc CreditAttribution: danielc commented 25 April 2005 at 18:40

Judicious use of @ is important. For example, they're a bad idea when including files. At the same time, there is no downside to suppressing error messages for function calls when failures of the given function are handled -- which they are in this case.

Log in or register to post comments

Comment #8

Cvbge CreditAttribution: Cvbge commented 16 August 2005 at 18:12

To test this I've created simple block:

<?php
echo "This is a test";
db_query("HELLO WORLD");
?>

When the block was displayed the error was logged and displayed too:

warning: pg_query(): Query failed: ERROR:  syntax error at or near "HELLO" at character 1 in ..../includes/database.pgsql.inc on line 45.

user error: 
query: HELLO WORLD in ..../includes/database.pgsql.inc on line 62.

But prefixing pg_query() with @ didn't change anything, the error was still displayed on the page.

Log in or register to post comments

Comment #9

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 17 January 2006 at 15:30

Priority:	Normal	» Minor
Status:	Needs review	» Needs work

Downgrading to minor and setting to "needs work".

Log in or register to post comments

Comment #10

Jaza CreditAttribution: Jaza commented 18 January 2007 at 01:03

Version:

x.y.z

» 6.x-dev

Moving to 6.x-dev.

Log in or register to post comments

Comment #11

klando CreditAttribution: klando commented 15 November 2007 at 23:54

db_query("set client_min_messages=FATAL");

will remove part of the message (there is other level of error messages)

warning: pg_query() [function.pg-query]: Query failed: in /usr/share/drupal6/includes/database.pgsql.inc on line 155.
user warning: query: HELLO WORLD in /usr/share/drupal6/includes/common.inc(1478) : eval()'d code on line 4.

I hope it can be set on pg_connect or around