Hi,

This module does not declare its dependencies. I was surprised when seeing it did not "require" the Metatag module. But after enabling it on its own, the PHP Fatal Error I got showed me it actually did.

Attached patch declares the correct dependencies. It also puts this module in the correct package (Meta Tag is not the "official" package - SEO is).

Kind regards

CommentFileSizeAuthor
domains_metatag.info.patch548 byteswadmiraal

Comments

artofeclipse’s picture

artofeclipse commented
Status: Needs review » Reviewed & tested by the community

Thanks for informing me regarding this issue, I applied this patch, now it should be in the dev branch, also you should use format-patch to generate your patchs this way you will claim the changes for you account in drupal

Status: Reviewed & tested by the community » Needs work

The last submitted patch, domains_metatag.info.patch, failed testing.

theroyal’s picture

theroyal commented
Title: Module does not declare dependencies » WSOD after enabeling this module without its dependency
Issue summary: View changes

I got WSOD only on the frontpage, and it was a panel page,
but after looking at the log file I noticed that it is because this module,
and when i tried to disable it i couldnt, so i enabeled the metatag module, then the WSOD disappeared.

below the errors from the log file:

[Sun Nov 23 01:31:08 2014] [error] [client ip.ip.ip.ip ] PHP Fatal error: Call to undefined function metatag_metatags_view() in /var/www/vhosts/example.com/httpdocs/sites/all/modules/domains_metatag/domains_metatag.module on line 47, referer: http://example.com/admin/reports/status
[Sun Nov 23 01:31:24 2014] [error] [client ip.ip.ip.ip ] PHP Fatal error: Call to undefined function metatag_metatags_view() in /var/www/vhosts/example.com/httpdocs/sites/all/modules/domains_metatag/domains_metatag.module on line 47

artofeclipse’s picture

artofeclipse commented
Status: Needs work » Fixed

Fixed on dev branch.

artofeclipse’s picture

artofeclipse commented
Status: Fixed » Closed (fixed)