Change call order of callbacks and SourceMigration
It's more useful to call callbacks before SourceMigration allow to process field value to extract external id if it is complex.

Like

external id is 'views'
xml field contains 'views 7.x-2.x-dev'
callback explode it and return 'views'

CommentFileSizeAuthor
#2 1994232-change_order_callbacks_and_sourceMigration-1.patch1.49 KBigor.ro

Comments

igor.ro’s picture

igor.ro commented
Status: Active » Needs review

here is the patch

igor.ro’s picture

igor.ro commented
StatusFileSize
new 1994232-change_order_callbacks_and_sourceMigration-1.patch1.49 KB
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Closed (won't fix)

Depending on the application, it may make more sense to process a given callback before or after sourceMigration (some scenarios may want to be working with the destination values rather than the source values). Your scenario may be more common, but given that it's already been this way as long as we've had callbacks, changing the order would risk break existing code - I would not change it at this time. You can always do the work you would do in the callback in prepareRow() to make sure it happens before sourceMigration.