When a field got updated by using field_attach_update , the module should mark the entity as needing re-indexing.

CommentFileSizeAuthor
#2 apachesolr-implements_hook_field_attach_update-1994326-7409832.patch597 bytestungscit

Comments

tungscit’s picture

tungscit commented
Version: 7.x-1.2 » 7.x-1.x-dev
tungscit’s picture

tungscit commented
StatusFileSize
new apachesolr-implements_hook_field_attach_update-1994326-7409832.patch597 bytes

Attached is a patch.

tungscit’s picture

tungscit commented
Status: Active » Needs review
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

Looks good, if someone can confirm this helps them we should mark it as RTBC

pwolanin’s picture

pwolanin commented

Looks good - or at least harmless enough! however, what's the use case - a field getting updates not in the context of a entity save?

I'm worried we'll be marking every entity 2x or more.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Needs work

The api states :

"This hook is invoked after the field module has performed the operation." and the field_attach_update function seems like an official API call that can be executed individually next to entity_save, delete, etc...

Should we add some static code that once a node is marked once per page load we do not mark it again?