Whilst setting up a performance testing environment I noticed that we can improve the implementation in node_block_access() to not do unnecessary calls to menu_get_object(); and node_type_get_types();.

CommentFileSizeAuthor
#3 without-patch-2.png177.08 KBalexpott
#3 with-patch.png140.46 KBalexpott
#3 1-2-interdiff.txt560 bytesalexpott
#3 1994468.node_block_access_perf.2.patch2.23 KBalexpott
#1 1994468.node_block_access_perf.1.patch2.16 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue tags: +needs profiling
StatusFileSize
new 1994468.node_block_access_perf.1.patch2.16 KB

Here's the patch

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 1994468.node_block_access_perf.2.patch2.23 KB
new 1-2-interdiff.txt560 bytes
new with-patch.png140.46 KB
new without-patch-2.png177.08 KB

Here's an xhprof of the function calls to node_block_access on the front page of a Drupal standard install with 2 nodes promoted...

Without the patch

without-patch-2.png

With the patch

with-patch.png

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks great.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Assigned: Unassigned » dries

Well... I wrote the patch and catch rtbc'd so this is Dries's :D

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

dries’s picture

dries commented
Assigned: dries » Unassigned

Automatically closed -- issue fixed for 2 weeks with no activity.