I was trying to figure out why my exported ical view display was missing its options when moving between environments -- we use features extensively for this -- and it turns out the date_ical_plugin_style_ical_feed does not implement "option_definition" which is required for exports.

I would think something like the following would work :

function option_definition() {
  $options = parent::option_definition();
  $options['cal_name'] = array('default' => array());
  $options['no_calname'] = array('default' => array());
  $options['disable_webcal'] = array('default' => array());
  return $options;
}
CommentFileSizeAuthor
#1 date_ical-option_definition.patch803 bytescoredumperror

Comments

coredumperror’s picture

Status: Needs review » Active
StatusFileSize
new803 bytes

Ah, I see the problem. The Date iCal style plugin didn't originally have any options in the old version. I migrated the row plugin's option_definition() function, but I didn't know what it did, so I wasn't aware that I'd need to define it for the style plugin.

Here's a patch of the suggestion you made. I've committed it to the dev version, too, but it won't appear there for several hours.

coredumperror’s picture

Status: Active » Needs review
coredumperror’s picture

Status: Active » Needs review

I wish we could delete useless comments, like this one.

tswaters’s picture

Status: Needs review » Reviewed & tested by the community

Wow, that was quick... go to lunch, return & it's done!

I applied this patch to my dev environment and can verify it works as expected.

Thanks!

coredumperror’s picture

Status: Reviewed & tested by the community » Fixed

That's excellent! Thanks for picking this up. I highly doubt that I would have been able to solve it on my own, if I ran into the problem you saw.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.