Needs work
Project:
Election
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Minor
Category:
Feature request
Assigned:
Reporter:
Created:
14 May 2013 at 21:02 UTC
Updated:
10 Nov 2016 at 17:33 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ricky.middaugh commentedAdding a patch for review. This add menu items that are simple redirects to other actions in the module. Because we're displaying the names of added elections in the menu, this means we need to clear the Drupal cache whenever an election is added, deleted, or modified.
Comment #2
ricky.middaugh commentedComment #3
pjcdawkins commentedI don't really understand what this patch solves.
Better documentation is certainly needed.
But the "lack of menu items" may have been fixed by various commits in the past 2 weeks: it used to be that an extra cache clear was needed before "Add new ..." would show up on
/elections.The structure in the Navigation menu (Elections -> Add new ...) seems to be clear to me. There might be a question as to whether the Navigation menu is the best place. But that's where the core Drupal "Add content" link sits:
A few comments on the patch itself:
drupal_goto()as a menu callback is an interesting but I think too hackish way to add menu items.Comment #4
pjcdawkins commentedComment #7
pjcdawkins commentedComment #8
pjcdawkins commentedThis needs a manual re-roll.
Comment #9
liam morlandRe-roll.
Comment #11
liam morlandRe-roll.
Comment #13
liam morlandWorking on a new patch.
Comment #14
liam morlandComment #15
liam morlandIf you would like this included in 7.x-1.0, please provide an updated patch in the next week or so.