Closed (fixed)
Project:
Election
Version:
7.x-1.x-dev
Component:
election_candidate
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
14 May 2013 at 21:12 UTC
Updated:
2 Jun 2013 at 17:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
ricky.middaugh commentedAdding a patch for review. This adds a new permission for the election_candidate module and will keep users from seeing candidates without the new permission. If they have it, they will still need the current permission to also be able to view the election.
Comment #2
ricky.middaugh commentedComment #3
pjcdawkins commentedThe problem with this is that it suggests if the permission is not granted, then the user won't be able to see candidates - actually the user still can see candidates, in places such as the post's page (election-post/%election_post), and in the voting form. I would rename it as something like "View Candidates tab", description "This shows an overview list of candidates in a tab for each election.".
I understand in your use case, the aim is just to reduce confusion, not actually a security consideration - is that right?
I was thinking of getting rid of the Candidates tab, but it may be useful to some. See the two attached patches for two more approaches. Or another idea might be to make it a setting per election.
Comment #4
ricky.middaugh commentedYou're correct that we just wanted to reduce confusion when we hid it - without more information on the page, people thought they could vote there.
I think the Candidates tab has a use to give more details about candidates than just a name. For example, it could include a picture of the candidate, some platform statement, stuff like that. Of the choices above, I would suggest making it a setting per election until we better decide what to do with that page.
Comment #5
pjcdawkins commentedOK. This is how we've used the tab, to give an idea:
http://uclu.org/election/14/candidates
Comment #6
pjcdawkins commentedTry this
Comment #7
pjcdawkins commentedCommitted the above.