UI comment:
When I click "Media" in a story, I get "Attached Media for xxxstory"
When I get there it says:

===
No media currently attached
> Upload media

[Cancel] [Attach via Manager] [Submit]
===

Clicking "Upload media" gives me the form for uploading.
Filling the form in - I clicked [Attach via Manager], which was obviosly wrong.

Is it that [Submit] submits the attachment? (I thought it would submit an entirely new node, which was not what I wanted.)

And [Attach via Manager] opens a manager, without attaching anything, right?

Suggestions:

1) Put [Submit] in the box with the upload-media-form (provided that it has nothing to do with the rest of the form). Possibly renaming it to [Submit and attach].

2) Change [Attach via Manager] to [Open Media Manager] or something like that.

Cheers!

Comments

rhys’s picture

Good ideas, I'll get on that right away.
Also makes it clearer for the people using the system.

rhys’s picture

Status: Active » Fixed

Committed to head. Let me know if you think this is more understandable.

Ibn al-Hazardous’s picture

Status: Fixed » Active

This was good, with one exception:

If I click Open Media Manager, I go to the generic media manager. From there, I can see no way to attach media to the story in question.

rhys’s picture

The idea is to simply click on the link which represents the media to be embedded. This is definitely not clear, so I'll have to figure out some way in which this can be cleared up.

Ibn al-Hazardous’s picture

What I did was:
Click the "Media > Add Media" link and upload an image.
Click a story link to view it.
In the story view I clicked Media, and in the Media view I clicked "Open Media Manager"
In the manager I clicked the link to the previously added image (link is: http://alfa.fria.nu/?q=media/manager&mid=1&op=edit where alfa.fria.nu is an alias for 127.0.0.1).
Now I am at the media edit page for that image, however - I try to click Submit to see if it is attached. (The links at the top read:
Add Media Delete Media Derivatives Edit Media(<= highlighted) Move Media View Media )
And I end up in the Media Manager again.

So the question is, am I falling around in another route than you anticipated?

rhys’s picture

The link instead of this

http://alfa.fria.nu/?q=media/manager&mid=1&op=edit

should be for the embedding:

http://alfa.fria.nu/?q=media/manager&mid=1&op=embed

There is definitely something here that I have to fix, I'll look into see what's causing it.

Ibn al-Hazardous’s picture

Here's the source code for the Media Manager I get to when I click [Open Media Manager]:

Media Manager

It should be embed instead of edit? I'll see what I can find.

rhys’s picture

Actually, it's supposed to be op=attach, since it's the attach process, my mistake.
But yes, it's supposed to be that. Let me check things out my end, and see if there is something not quite functional.

rhys’s picture

Status: Active » Fixed

I've updated the CVS with the solution to the problems with the media_attach module.

The media/manager section wasn't taking the operations correctly.

I've also fixed up the Submit button so there is one for the uploading while there, then there is the necessity to 'Submit Changes', such as when deleting attachments takes place, or captions.

Ibn al-Hazardous’s picture

Yes, it's working now.

Thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.