Not quite correct comments

corsix - December 10, 2007 - 19:44
Project:Citation Filter
Version:6.x-1.0
Component:Code
Category:bug report
Priority:minor
Assigned:cwgordon7
Status:closed
Description

<?php
/**
* Helper function for hook_filter.
*/
function citation_filter_replace($text, $format) {
?>
Would citation_filter_filter be more relevant than hook_filter? (same for citation_filter_append)

<?php
/**
* Helper function for hook_filter.
*/
function citation_filter_settings($format) {
?>
This is not a helper function.

<?php
  $form
['citation_filter'] = array(
   
'#type' => 'fieldset',
   
'#title' => t('HTML filter'),
   
'#collapsible' => TRUE,
  );
?>
Title should be the name of this filter, not the HTML filter.

#1

cwgordon7 - December 10, 2007 - 22:40
Assigned to:Anonymous» cwgordon7
Status:active» fixed

You're right, my comments were very sloppy. And again, you're right, it should NOT be named HTML filter, I was just copying-and-pasting code from filter.module and forgot to change it. This will be fixed in the next release (1-2 days).

#2

cwgordon7 - December 15, 2007 - 20:27

Fixed in new release.

#3

Anonymous - December 29, 2007 - 20:32
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.