/**
 * Helper function for hook_filter.
 */
function citation_filter_replace($text, $format) {

Would citation_filter_filter be more relevant than hook_filter? (same for citation_filter_append)

/**
 * Helper function for hook_filter.
 */
function citation_filter_settings($format) {

This is not a helper function.

  $form['citation_filter'] = array(
    '#type' => 'fieldset',
    '#title' => t('HTML filter'),
    '#collapsible' => TRUE,
  );

Title should be the name of this filter, not the HTML filter.

Comments

cwgordon7’s picture

cwgordon7 commented
Assigned: Unassigned » cwgordon7
Status: Active » Fixed

You're right, my comments were very sloppy. And again, you're right, it should NOT be named HTML filter, I was just copying-and-pasting code from filter.module and forgot to change it. This will be fixed in the next release (1-2 days).

cwgordon7’s picture

cwgordon7 commented

Fixed in new release.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.