Closed (fixed)
Project:
Doubleclick for Publishers (DFP)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 May 2013 at 10:52 UTC
Updated:
1 Jun 2013 at 23:10 UTC
Under certain circumstances, the current implementation of hook_entity_view throws some PHP warnings:
Warning: Invalid argument supplied for foreach() in dfp_entity_view() (line 174 of /modules/dfp/dfp.module).
Furthermore I think it's not really efficient to do that term category calculation on every entity view, even if this feature isn't activated at all (at least if I understood the configuration options correctly).
Attached patch fixes the PHP warning and ads a check if the term category feature is activated.
| Comment | File | Size | Author |
|---|---|---|---|
| dfp_hook_entity_view_improvements.patch | 1.38 KB | mh86 |
Comments
Comment #1
bleen commentedthis is great ... thanks!
Committed