Closed (fixed)
Project:
Geocoder
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 May 2013 at 18:21 UTC
Updated:
29 Mar 2016 at 06:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
beeradb commentedComment #2
beeradb commentedComment #3
Brandonian commentedThanks for the patch, @beeradb. Looks good, committed.
http://drupal.org/commitlog/commit/27950/8e531f4dc6a8224a9dac978397fbfba...
Comment #5
Robert_W commentedThe patch works, but I had to combine several fields of the entity before geocoding them. The current patch doesn't give you access to the entity object, so I modified the patch to include the entity object so that you can access fields other than the source field.
I created the patch from the 7.x-1.2 version (latest stable at the moment) because that's the version I'm working with.
Comment #6
Robert_W commentedComment #7
_wdm_ commentedIt also seems like a good idea to have a hook in the geocoder function.
Comment #8
rudiedirkx commentedI know nothing about the geocoder() function (or its alter), because I've never used it.
I think the
geocoder_geocode_valuesalter is 'wrong', because if you need the entity, you should make your own virtual encodable field. That's why #2159925: Geocode from virtual fields/entity property instead of just real fields exists.@_wdm_ You should probably create a new issue for that alter.
Comment #10
polComment #11
adamps commentedIt looks to me like the issue was fixed and the wrong status was picked by mistake.