Calling module_implements loads up files. We don't want to do this. Thus this needs to be cached.

CommentFileSizeAuthor
#4 advagg-1996828-4-add-in-full-cache.patch7.2 KBmikeytown2
#1 advagg-1996828-1-cache-module-implements.patch863 bytesmikeytown2

Comments

mikeytown2’s picture

mikeytown2 commented
Status: Active » Fixed
StatusFileSize
new advagg-1996828-1-cache-module-implements.patch863 bytes

Shaves ~10ms off of the request for an advagg cache hit. Following patch has been committed

mikeytown2’s picture

mikeytown2 commented

I've gotten this down to core: 7ms, advagg: 9ms using microtime(TRUE) timers. Using xdebug it shows core: 32ms, advagg: 42ms. ~30% slower when we are talking about 2ms isn't a big issue in my opinion. If I wanted to get more out of it I could cache advagg_merge_plans or _advagg_aggregate_css/js but that would give me a lower cache hit ratio for that cache due to inlined output. Nonetheless something to think about.

mikeytown2’s picture

mikeytown2 commented

By adding caching at the highest level I got this to be faster than core.
microtime: 4ms
xdebug: 17ms

I'll build a setting to turn caching on and off.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new advagg-1996828-4-add-in-full-cache.patch7.2 KB

The following patch has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.